Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebKitBrowser] Updating IndexedDB to match version 2.42 of WPEWebKit #258

Merged
merged 32 commits into from
Jan 17, 2024
Merged

[WebKitBrowser] Updating IndexedDB to match version 2.42 of WPEWebKit #258

merged 32 commits into from
Jan 17, 2024

Conversation

VeithMetro
Copy link
Contributor

@VeithMetro VeithMetro commented Oct 23, 2023 •
edited
Loading

No description provided.

@modeveci modeveci requested a review from MFransen69 October 23, 2023 10:12
modeveci
modeveci requested changes Oct 23, 2023
View reviewed changes
WebKitBrowser/WebKitImplementation.cpp Outdated Show resolved Hide resolved
WebKitBrowser/WebKitImplementation.cpp Outdated Show resolved Hide resolved
WebKitBrowser/JSPP.config Outdated Show resolved Hide resolved
WebKitBrowser/CMakeLists.txt Outdated Show resolved Hide resolved
WebKitBrowser/CMakeLists.txt Outdated Show resolved Hide resolved
WebKitBrowser/WebKitImplementation.cpp Outdated Show resolved Hide resolved
WebKitBrowser/WebKitImplementation.cpp Outdated Show resolved Hide resolved
WebKitBrowser/WebKitImplementation.cpp Outdated Show resolved Hide resolved
WebKitBrowser/WebKitImplementation.cpp Outdated Show resolved Hide resolved
@VeithMetro VeithMetro requested a review from modeveci October 24, 2023 07:37
@VeithMetro VeithMetro requested a review from MFransen69 October 25, 2023 07:48
@modeveci
Copy link
Contributor

@VeithMetro , were you able to test on RPI these changes? and seeing QuotaExceededError in case of exceeded?

@VeithMetro
Copy link
Contributor Author

VeithMetro commented Oct 25, 2023 •
edited
Loading

@modeveci I tested the plugin after my changes on RPI, I changed indexeddbenabled to true in the config, and didn't see anything worrying in the logs. But I haven't seen QuotaExceededError either - what can I do to exceed the quota in order to check if I get this error?

@modeveci
Copy link
Contributor

I thin you can check these examples, and play with the values you provided with config files:
https://developer.mozilla.org/en-US/docs/Web/API/IndexedDB_API#examples

@VeithMetro
Copy link
Contributor Author

@modeveci I tested indexeddb with the examples that you suggested:

  1. https://mdn.github.io/dom-examples/to-do-notifications/
  2. https://mdn.github.io/dom-examples/indexeddb-examples/idbcursor/
  3. https://mdn.github.io/dom-examples/indexeddb-examples/idbindex/
  4. https://mdn.github.io/dom-examples/indexeddb-examples/idbkeyrange/

and also played with the settings. It looks like everything works on my end - if indexeddb is disabled in the config, then nothing shows in these examples, and you can't add anything to the database, as expected. Then if you enable indexeddb in the config, you can see all database items properly displayed, and it is also possible to create and add new ones. When I set the quota too low, then the database was no longer displayed (if it was already too big), or it was not possible to add anything new to it.

@VeithMetro VeithMetro requested a review from modeveci November 7, 2023 14:16
@VeithMetro VeithMetro changed the title [WbKitBrowser] Updating WbKitBrowser plugin to version 2.42 of WPEWebKit [WebKitBrowser] Updating IndexedDB to match version 2.42 of WPEWebKit Nov 30, 2023
MFransen69
MFransen69 requested changes Jan 2, 2024
View reviewed changes
WebKitBrowser/WebKitImplementation.cpp Outdated Show resolved Hide resolved
WebKitBrowser/WebKitImplementation.cpp Outdated Show resolved Hide resolved
WebKitBrowser/WebKitImplementation.cpp Show resolved Hide resolved
WebKitBrowser/WebKitImplementation.cpp Show resolved Hide resolved
VeithMetro and others added 7 commits January 8, 2024 09:08
@VeithMetro VeithMetro requested a review from MFransen69 January 17, 2024 07:47
@VeithMetro VeithMetro mentioned this pull request Jan 17, 2024
Merged
@VeithMetro VeithMetro merged commit 027962f into WebPlatformForEmbedded:master Jan 17, 2024
16 checks passed
modeveci pushed a commit that referenced this pull request Feb 13, 2024
@VeithMetro @modeveci
[WebKitBrowser] Updating IndexedDB to match version 2.42 of WPEWebKit (…
90deedc 
…#258)

* Adding the new options of WebKit to the main CMakeLists.txt

* Marking consoleMessageSentCallback as DEPRECATED since it was removed

* Adding the new option to each conf.in file

* Adding the new option to each .config file

* Updating everything to the WebKit API version 2.42

* Minor formatting adjustemtns

* Removing the initial values of indexdb options in cmakelist

* Making sure that the correct version are inside version checks, removing duplicated code

* Other option of indexdb will be only available if indexdb is enabled

* Bringing back values for enabled and path of indexdb options

* Adding a persistant path substitution

* Removing c_str() as it is no longer necessary

* Fixing how the subsitution is done

* Adding a use of USE_EXACT_PATHS for indexedDBPath

* Changing IndexedDBSize and IndexedDBTotalSize to DecUInt16

* Removing support for indexedDB for previous WebKit API versions

* Moving some changes to different branches

* Final formatting changes

* Making sure WebKitBrowser builds correctly for WebKit API pre 2.42

* Moving IndexedDBPath section to 2.42 only, resolving merge conflicts

* Resolving some more merge conflicts with remove config files

* Renaming IndexedDBSize to OriginStorageRatio and IndexedDBTotalSize to TotalStorageRatio

* Renaming configurations to match the newest changes
@VeithMetro VeithMetro deleted the development/webkitbrowser-2.42-update branch February 15, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFransen69 MFransen69 MFransen69 approved these changes

@modeveci modeveci modeveci approved these changes

@HaseenaSainul HaseenaSainul Awaiting requested review from HaseenaSainul

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VeithMetro @modeveci @MFransen69