-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump version for 0.2.0-rc2 release; bump keri to 1.2.4 #356
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
==========================================
+ Coverage 93.71% 93.78% +0.06%
==========================================
Files 37 37
Lines 8293 8415 +122
==========================================
+ Hits 7772 7892 +120
- Misses 521 523 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the release strategy here? Is main to become 0.2.0-rc2? Typically in keripy the change would be merged to @kentbull asked me to do a release, is this from |
whoops, I made a mistake here. I should have targeted the 0.2.0-rc1 branch. I forgot about the release process. I'll make a 0.2.0-rc2 branch and then keep this in mind for future release candidate changes. |
There should just be a |
Well, the change is in main now because it was merged? At this point you may as well delete the Given the minimal changes I don't see this hurting, but it would be nice to see PRs merged using the same strategy across repos. |
Yes, I will make |
OK with me but the branch should be called |
We actually rename the branch in keripy and add a tag. Your suggestion might be an improvement @iFergal |
To clarify, the tags remain a reference point of when the tag was made, but the branch always has the latest name (for that release) - and its name reflects the latest "version". |
Ah, ok, and they have the final version name now in keripy since those are fully released. My mistake. I've only ever seen |
No description provided.