Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: basic boot password should be able to contain colon characters #349

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Jan 13, 2025

Fixes an issue that did not allow --experimental-boot-password to contain : characters.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@f4a21b3). Learn more about missing BASE report.
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #349   +/-   ##
=======================================
  Coverage        ?   93.89%           
=======================================
  Files           ?       36           
  Lines           ?     8162           
  Branches        ?        0           
=======================================
  Hits            ?     7664           
  Misses          ?      498           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenkan lenkan merged commit d49436a into WebOfTrust:main Jan 20, 2025
5 checks passed
@lenkan lenkan deleted the fix-boot-password branch January 20, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants