Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 400 for invalid end role signatures #344

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

iFergal
Copy link
Collaborator

@iFergal iFergal commented Jan 6, 2025

Feedback to client instead of passing the exception.

Based on the test, passing bad signatures causes kering.ValidationError to be thrown from validateSigs before kering.UnverifiedReplyError is hit.

@iFergal iFergal self-assigned this Jan 6, 2025
Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iFergal iFergal merged commit f4a1032 into WebOfTrust:main Jan 7, 2025
3 checks passed
@iFergal iFergal deleted the fix/endRole400 branch January 7, 2025 17:50
@iFergal
Copy link
Collaborator Author

iFergal commented Jan 7, 2025

@2byrds OK, running multi-sig tests this was a mistake. UnverifiedReplyError is thrown before all signatures are gathered. Will create a new PR separating the two and bring back the pass.

@kentbull
Copy link
Contributor

Agreed, yes, I am hitting the same exact problem. UnverifiedReplyError is thrown while the end role is in escrow waiting for all signatures to arrive.

@iFergal
Copy link
Collaborator Author

iFergal commented Jan 10, 2025

@kentbull fixed but still waiting for review, will add you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants