Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#24 block save to render php #32

Merged
merged 10 commits into from
Mar 23, 2018

Conversation

efuller
Copy link
Contributor

@efuller efuller commented Mar 23, 2018

Closes #24

DESCRIPTION

  • Lots of digging to find out that block versioning was a thing.
  • Added deprecation properties to each block.
  • The related posts block is still a work in progress. Both it and the github-gist block implement PHP rendering at them moment.

STEPS TO VERIFY

Check block index.js files and make sure there is a deprecated property.

DOCUMENTATION

https://github.com/WebDevStudios/wds-gutenberg/wiki/Block-Versioning

@efuller
Copy link
Contributor Author

efuller commented Mar 23, 2018

@coreymcollins Assigning this over to you since I think you're most familiar with it!

@coreymcollins coreymcollins merged commit 4573cbd into master Mar 23, 2018
@coreymcollins
Copy link
Contributor

I think this is looking good! I'm going to add an issue to clean up the Two Column Block code a bit, because I'm sure we can break the various functions being used into either individual files to import or something else to make the file a bit more readable and DRY.

For the purposes of this issue, though, I think we're good!

@jomurgel jomurgel mentioned this pull request Apr 16, 2018
5 tasks
@gregrickaby gregrickaby deleted the feature/#24-block-save-to-render-php branch August 24, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants