Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[interpreter] Fix JS module invocation #1829

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[interpreter] Fix JS module invocation #1829

merged 1 commit into from
Oct 8, 2024

Conversation

rossberg
Copy link
Member

@rossberg rossberg commented Oct 7, 2024

Fixes #1828.

@rossberg rossberg requested a review from backes October 7, 2024 20:57
@rossberg rossberg mentioned this pull request Oct 7, 2024
Closed
backes
backes approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@backes backes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems to fix it.

@backes
Copy link
Member

backes commented Oct 8, 2024

I am going ahead and merging this, so we can import the new tests in V8.

@backes backes merged commit 2a30893 into wasm-3.0 Oct 8, 2024
@backes backes mentioned this pull request Oct 8, 2024
Closed
@backes
Copy link
Member

backes commented Oct 8, 2024

Sorry, I didn't test enough, this fix breaks other things :/

assert_invalid is now being translated into assert_invalid(module(bytes)), which then fails in module already. We should pass the raw bytes instead.

@rossberg rossberg deleted the fix-of_module branch October 8, 2024 10:37
@rossberg rossberg mentioned this pull request Oct 8, 2024
Merged
@rossberg
Copy link
Member Author

rossberg commented Oct 8, 2024

Ah, I shouldn't do late night fixes. Please try #1832.

This was referenced Oct 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@backes backes backes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossberg @backes