Draft of spec for jspi #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Jul 19, 2024
syg
reviewed
Jul 31, 2024
syg
reviewed
Sep 25, 2024
There was a problem hiding this comment.
The general direction wfm. High-level comments
- I don't feel like exposing the Suspending/Promising prototypes on the WebAssembly global is what you want?
- Please do a once-over to make sure each algorithm step ends with a period, I didn't comment on all of them.
- Please do a once-over for oxford comma usage.
- Please use the standard boilerplate for Abstract Closures: "Let foo be a new Abstract Closure with {no parameters, parameters (bar, baz)} that captures quux, quz and performs the following steps when called:"
Also tightened up language obout requiring traps when promise/suspending not correctly lined up.
Some of the changes that follow from reviewer's remarks. Co-authored-by: Shu-yu Guo <[email protected]>
Make it clear that a 'long jump' in the meta-interpreter is being affected.
syg
reviewed
Oct 24, 2024
Some minor tweaks in response to reviewer's remarks.
syg
reviewed
Oct 29, 2024
syg
reviewed
Oct 29, 2024
Co-authored-by: Shu-yu Guo <[email protected]>
Co-authored-by: Shu-yu Guo <[email protected]>
Co-authored-by: Shu-yu Guo <[email protected]>
use 'marker' suffix to better distinguish Suspending objects from functions
Small changes, responding to remarks by reviewer.
Small tweak: Add an explanation for the role of the map Big tweak: Arrange to throw a JS RuntimeError rather than trap when JSPI usage not properly balanced.
Tidy up punctuation.
Clean up throwing exceptions from JS (a little bit)
|
Merged with repo spec. It is possible more changes will be needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of a specification for jspi.