Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug #190

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix: bug #190

merged 1 commit into from
Nov 6, 2024

Conversation

ieow
Copy link
Contributor

@ieow ieow commented Nov 6, 2024

use factors's curve instead of tkeycurve

Motivation and Context

Jira Link:

Description

Bug: we should use factor's Curve to derive factor pub instead of tkey.tss's curve

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@ieow
fix: bug
59b2ed8 
use factors's curve instead of tkeycurve
@ieow ieow marked this pull request as ready for review November 6, 2024 10:39
himanshuchawla009
himanshuchawla009 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@himanshuchawla009 himanshuchawla009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@himanshuchawla009 himanshuchawla009 merged commit bf88bcb into master Nov 6, 2024
3 checks passed
@himanshuchawla009 himanshuchawla009 deleted the fix/addDescriptionFactorBug branch November 6, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshuchawla009 himanshuchawla009 himanshuchawla009 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ieow @himanshuchawla009