[1.1.19] mv hdfs file #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-kkhuang
changed the base branch from
dev-1.1.17-webank
to
dev-1.1.18-webank
casionone
changed the base branch from
dev-1.1.18-webank
to
dev-1.1.19-webank
casionone
approved these changes
Nov 28, 2023
Comment on lines
1180
to
1182
| @RequestParam(value = "filepath", required = false) String filePath, | ||
| @RequestParam(value = "isRecursion", required = false) Boolean isRecursion, | ||
| @RequestParam(value = "filePermission", required = false) String filePermission) |
There was a problem hiding this comment.
filepath 和 filePermission 的 required 与后面参数处理不一致
| return Message.error( MessageFormat.format(PARAMETER_NOT_BLANK, filePermission)); | ||
| } | ||
| if (null == isRecursion) { | ||
| isRecursion = true; |
There was a problem hiding this comment.
这个是不是没必要在代码里判断， @RequestParam 可以给默认值
aiceflower
reviewed
Dec 18, 2023
Comment on lines
1193
to
1197
| Matcher matcher = Pattern.compile("[0-7]{3}").matcher(filePermission); | ||
| if (matcher.matches()) { | ||
| return Message.error(MessageFormat.format(PERMISSION_FORMAT_ERROR, filePermission)); | ||
| } | ||
| } |
There was a problem hiding this comment.
There's a slight problem with the logic. Please fix it.
casionone
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
EngineConn-Core defines the the abstractions and interfaces of the EngineConn core functions.
The Engine Service in Linkis 0.x is refactored, EngineConn will handle the engine connection
and session management.
Related issues/PRs
Related issues: #590
Related pr:#591
Brief change log
Checklist