[1.1.17]ECM Support file download #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casionone
reviewed
Oct 23, 2023
| private final Logger logger = LoggerFactory.getLogger(ECMRestfulApi.class); | ||
|
|
||
| @RequestMapping(path = "/downloadEngineLog", method = RequestMethod.POST) | ||
| public void downloadEngineLog( |
casionone
reviewed
Oct 23, 2023
| logger.error("download failed", e); | ||
| response.reset(); | ||
| response.setCharacterEncoding(Consts.UTF_8.toString()); | ||
| response.setContentType("text/plain; charset=utf-8"); |
casionone
reviewed
Oct 23, 2023
| @@ -33,7 +33,8 @@ public enum EngineconnServerErrorCodeSummary implements LinkisErrorCode { | |||
| 11110, | |||
| "the parameters of engineConnInstance and ticketId are both not exists.(engineConnInstance 和ticketId 的参数都不存在.)"), | |||
| LOG_IS_NOT_EXISTS(11110, "Log directory {0} does not exists.(日志目录 {0} 不存在.)"), | |||
| FAILED_TO_DOWNLOAD(911115, "failed to downLoad(下载失败)"); | |||
| FAILED_TO_DOWNLOAD(911115, "failed to downLoad(下载失败)"), | |||
| FILE_IS_OVERSIZE(911116, "Download file has exceeded 100MB(下载文件已经超过100M)"); | |||
There was a problem hiding this comment.
FILE_IS_OVERSIZE(911116, "Download file size has exceeded 100MB(下载文件已超过100M)");
casionone
changed the title
v-kkhuang
changed the title
v-kkhuang
changed the base branch from
dev-1.1.16-webank
to
dev-1.1.17-webank
casionone
reviewed
Oct 26, 2023
| response.addHeader( | ||
| "Content-Disposition", | ||
| "attachment;filename=" + instance.replace(":", "_") + "_" + logType + ".txt"); | ||
| response.addHeader("Content-Length", fileSizeInBytes + ""); |
There was a problem hiding this comment.
add annotation for filename example
// filename eg:xxxxx
val filename= instance.replace(":", "") + "" + logType + ".txt"
.....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
ECM Support file download
Related issues/PRs
Related issues: apache#4949
Brief change log
Checklist