Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【1.1.16】fix reading configuration containing space errors #295

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

v-kkhuang
Copy link

@v-kkhuang v-kkhuang commented Sep 25, 2023

What is the purpose of the change

fix reading configuration containing space errors

Related issues/PRs

Related issues: apache#4926

Brief change log

  • Define the core abstraction and interfaces of the EngineConn Factory;
  • Define the core abstraction and interfaces of Executor Manager.

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

case _: Boolean => trimValue.map(_.toBoolean)
case _: TimeType => trimValue.map(new TimeType(_))
case _: ByteType => trimValue.map(new ByteType(_))
case null => trimValue
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add unit test

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@v-kkhuang v-kkhuang changed the title 【wip】【1.1.16】fix conf error 【1.1.16】fix reading configuration containing space errors Oct 7, 2023
@casionone casionone merged commit d19d2dd into dev-1.1.16-webank Oct 7, 2023
10 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants