Fix(sage/upgrade) option name #389
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create-discord-activity
@robojs/ai
@robojs/ai-voice
create-robo
@robojs/server
@robojs/better-stack
@roboplay/plugin-confessions
@robojs/dev
@roboplay/plugin-gpt
@robojs/maintenance
@robojs/moderation
@roboplay/plugin-poll
@robojs/sync
robo.js
@roboplay/sage
commit: |
Pkmmte
reviewed
Dec 1, 2024
| @@ -58,7 +58,8 @@ async function upgradeAction(options: UpgradeOptions) { | |||
| const update = await checkUpdates(packageJson, config, true) | |||
| logger.debug(`Update payload:`, update) | |||
|
|
|||
| await updateRobo(plugins, config, options.autoAccept) | |||
| const autoAccept = options.yes | |||
| await updateRobo(plugins, config, autoAccept) | |||
There was a problem hiding this comment.
Why not just pass options.yes inline instead of creating a dedicated variable used only once?
There was a problem hiding this comment.
Hey, just thought it would make things clearer, I can pass it as a one liner no issue if required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please accept and merge this as I have introduced a bug in the previous one, the type inference was not done properly and it introduced autoAccept instead of yes in the command options when parsed, this is wrong thus turning into code never being correctly ran, this fixes it, the option name as to be
yesin the types.Let me know if you think of a better way of doing it.