Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.lock: fix version of tuic[-quinn] #645

Closed
wants to merge 1 commit into from

Conversation

zi3m5f
Copy link

@zi3m5f zi3m5f commented Nov 8, 2024

The source of tuic and tuic-quinn was updated by a recent dependabot PR but the version was not updated:
#635 (review)

🤔 This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Changelog is provided or not needed

@ibigbug ibigbug requested a review from Itsusinn November 8, 2024 11:33
@Itsusinn
Copy link
Member

Itsusinn commented Nov 8, 2024

Seems it's upstream(dependabot) bug.

@Itsusinn
Copy link
Member

Itsusinn commented Nov 8, 2024

@zi3m5f
Copy link
Author

zi3m5f commented Nov 8, 2024

Could be the fault is with tuic and they didn't adjust the version in Cargo.toml:
https://github.com/Itsusinn/tuic/blob/v1.3.2/Cargo.toml#L7
Itsusinn/tuic@09dc5df

@zi3m5f zi3m5f closed this Nov 8, 2024
@Itsusinn
Copy link
Member

Itsusinn commented Nov 8, 2024

Right, that's my fault.
Same cargo metadata version, but different git tag, different git hash

@zi3m5f zi3m5f deleted the fix-tuic-version branch November 8, 2024 12:55
@zi3m5f
Copy link
Author

zi3m5f commented Nov 8, 2024

No problem and sorry for not spotting it directly ;)

@zi3m5f zi3m5f mentioned this pull request Nov 8, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants