Feat/add docker test for wg #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibigbug
reviewed
Apr 9, 2024
clash_lib/src/proxy/wg/wireguard.rs
Outdated
Comment on lines
72
to
73
| tracing::debug!("config: private key: {:x?}, endpoint public key: {:x?}, remote endpoint: {}, source peer ip: {}, source peer ipv6: {:?}, keepalive seconds: {:?}, allowed ips: {:?}, reserved bits: {:?}", | ||
| config.private_key.to_bytes(), config.endpoint_public_key.to_bytes(), config.remote_endpoint, config.source_peer_ip, config.source_peer_ipv6, config.keepalive_seconds, config.allowed_ips, config.reserved_bits); |
There was a problem hiding this comment.
Suggested change
| tracing::debug!("config: private key: {:x?}, endpoint public key: {:x?}, remote endpoint: {}, source peer ip: {}, source peer ipv6: {:?}, keepalive seconds: {:?}, allowed ips: {:?}, reserved bits: {:?}", | |
| config.private_key.to_bytes(), config.endpoint_public_key.to_bytes(), config.remote_endpoint, config.source_peer_ip, config.source_peer_ipv6, config.keepalive_seconds, config.allowed_ips, config.reserved_bits); | |
| tracing::debug!("config: endpoint public key: {:x?}, remote endpoint: {}, source peer ip: {}, source peer ipv6: {:?}, keepalive seconds: {:?}, allowed ips: {:?}, reserved bits: {:?}", | |
| config.endpoint_public_key.to_bytes(), config.remote_endpoint, config.source_peer_ip, config.source_peer_ipv6, config.keepalive_seconds, config.allowed_ips, config.reserved_bits); |
There was a problem hiding this comment.
please don't print out the private key in logs
There was a problem hiding this comment.
sorry, it's a line for debug, forgot to delete
great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Motivation: I wish to change some code in wireguard module, but the test is hard, i can only test it by running the whole app
📝 Changelog
feat: add docker test for wg
☑️ Self-Check before Merge