Fix Invocation count wrong for multiple namespace

Fixes openfaas#1413 Fixes openfaas/faas-netes#707 This adds both namespace and non-namespace scoped counts of invocation to metric agregation and fixes the Gateway UI not updating the invocation count automatically without a page reload. Signed-off-by: Alistair Hey <[email protected]>
Waterdrips · Nov 11, 2020 · b2b4242 · b2b4242
1 parent bb9ba03
commit b2b4242
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/gateway/assets/index.html b/gateway/assets/index.html
@@ -124,7 +124,7 @@ <h1 style="flex: 1 1 auto;"><img src="img/logo-text.svg" class="md-logo"></h1>
 
                                 <md-input-container class="md-block" flex-gt-sm>
                                     <label>Invocation count</label>
-                                    <input ng-model="function.invocationCount" type="text" readonly="readonly">
+                                    <input value="{{ function.invocationCount }}" type="text" readonly="readonly">
                                 </md-input-container>
 
                                 <md-input-container class="md-block" flex-gt-sm ng-show="allNamespaces.length > 1">

diff --git a/gateway/assets/script/bootstrap.js b/gateway/assets/script/bootstrap.js
@@ -222,6 +222,16 @@ app.controller("home", ['$scope', '$log', '$http', '$location', '$interval', '$f
                       $scope.selectedFunction = undefined;
                   }
                 }
+
+                if ($scope.selectedFunction) {
+                    response.data.some(function(entry) {
+                        if (entry.name === $scope.selectedFunction.name) {
+                            $scope.selectedFunction.invocationCount = entry.invocationCount
+                            return true
+                        }
+                    });
+                }
+
             });
         };
 

diff --git a/gateway/metrics/add_metrics.go b/gateway/metrics/add_metrics.go
@@ -76,6 +76,7 @@ func AddMetricsHandler(handler http.HandlerFunc, prometheusQuery PrometheusQuery
 }
 
 func mixIn(functions *[]types.FunctionStatus, metrics *VectorQueryResponse) {
+
 	if functions == nil {
 		return
 	}
@@ -88,11 +89,10 @@ func mixIn(functions *[]types.FunctionStatus, metrics *VectorQueryResponse) {
 	for i, function := range *functions {
 		for _, v := range metrics.Data.Result {
 
-			if v.Metric.FunctionName == fmt.Sprintf("%s.%s", function.Name, function.Namespace) {
+			if v.Metric.FunctionName == function.Name || v.Metric.FunctionName == fmt.Sprintf("%s.%s", function.Name, function.Namespace) {
 				metricValue := v.Value[1]
 				switch metricValue.(type) {
 				case string:
-					// log.Println("String")
 					f, strconvErr := strconv.ParseFloat(metricValue.(string), 64)
 					if strconvErr != nil {
 						log.Printf("Unable to convert value for metric: %s\n", strconvErr)