Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows build instructions for the ggml plugin #244

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

hydai
Copy link
Member

@hydai hydai commented Jul 23, 2024

Explanation

In this PR, I added a section to show how to setup the dependencies we need for building the ggml plugin on the Windows platform, including how to execute an example.

Related issue

None.

What type of PR is this

/kind documentation

Proposed Changes

A new section for the building and execution process.

@hydai hydai requested a review from juntao July 23, 2024 17:37
Copy link
Member

juntao commented Jul 23, 2024

Hello, I am a PR summary agent on flows.network. Here are my reviews of code commits in this PR.


Commit d3b9d8c8a9ab67bf38f66190f3e7ab97380eb4b6

  • The patch adds instructions for building the ggml plugin on Windows systems.
  • This is significant as it expands the compatibility of the software to a broader range of operating systems, increasing its usability.
  • Key steps include installing dependencies such as CUDA Toolkit (optional), Visual Studio 2022 Community Edition, cmake, git, and ninja-build.
  • The build process involves using the Developer PowerShell for VS 2022 to clone the WasmEdge repository, compile it with specific configurations, and then execute the WASI-NN plugin with a llama example.
  • The patch also provides instructions on how to enable or disable CUDA during the build process.
  • Finally, it includes a section on setting environment variables and executing the plugin using the llama example.

Copy link
Member

@juntao juntao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juntao juntao merged commit 4312ae6 into main Aug 5, 2024
6 checks passed
@juntao juntao deleted the hydai-patch-1 branch August 5, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants