-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add neural speed backend #226
Conversation
Signed-off-by: grorge <[email protected]>
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall, the Pull Request titled "Add neural speed backend" introduces documentation updates and instructions for integrating the WASI-NN Neural Speed Backend. The patch brings valuable information, but there are potential issues that need attention. The highlighted potential problems include the introduction of a new dependency on Neural Speed without addressing version compatibility or conflicts with existing dependencies. This could lead to compatibility issues in the future. Additionally, the patch includes sudo usage for package installation, posing security risks if the source is not verified. Clear verification and package manager usage guidance should be provided. Lastly, the configuration complexity may increase with the addition of a new backend, emphasizing the need for streamlined and user-friendly instructions to prevent confusion or errors during the build process. Furthermore, the update of the backend name from "OpenVINO" to "Neural Speed" raises concerns about inconsistent terminology. Ensuring uniformity in naming conventions throughout the codebase is crucial, and verifying the official designation of "Neural Speed" is recommended. In summary, while the patch enhances documentation and integration instructions, addressing dependency issues, security concerns, and maintaining consistent terminology are crucial for a successful integration of the Neural Speed backend into the system. DetailsCommit 275151dbe368b98ab2578660862f313961d30495Key changes:
Potential problems:
Overall, the patch introduces valuable information for utilizing the Neural Speed backend but could benefit from addressing the potential problems mentioned above. Commit f2ce7a9c67c0f6cf672021f5747096e25a99f653Key Changes:
Potential Problems:
Overall, the changes seem straightforward and mainly involve updating the documentation to reflect the correct backend name. It would be beneficial to verify if there are any additional code changes or impacts on other parts of the system due to this modification. |
Signed-off-by: grorge <[email protected]>
@grorge123 |
Explanation
Add neural speed backend install tutorial.
Related issue
WasmEdge/WasmEdge#3260
What type of PR is this
/kind documentation