New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening of Ulduar #1864

Merged

sejtalk merged 32 commits into master from opening-of-ulduar

Jul 22, 2021

Contributor

sejtalk commented Mar 25, 2021 •

edited

Loading

Changelog:

Ulduar is closed again.
You can send an expedition to open Ulduar.

How to test:

Try to open Ulduar(you need to own land in Northrend and be Emperor) and make sure event work correctly.

sejtalk added 19 commits

March 23, 2021 21:52


          added decision to open ulduar and first event

277bc39


          finished ulduar expedition event code

44bf2e9


          added explorers.tga event picture(GIH)

ae7738c


          added ulduar event picture(GIH)

d68334a


          closed down ulduar since you can open it now(GDC)

edf1ebf


          moved the decision to correct place(GDC)

d075875


          added code for event pictures

7d75210


          added open_ulduar decision icon(GIH)

b6a082a


          added ulduar decision loc

ce00f37


          changed conditions in ulduar decision

386ea2e


          added partial event loc

6143e88


          added more partial loc

ce9c378


          explorer who discovers ulduar gets prestige

59af9f5


          added more ulduar loc

dbbd69a


          added more ulduar loc

41cde50


          added code for open ulduar icon

a04b50e


          fixed the bug that made decison unavaible

0850b6e


          added correct pictures to the events and shortened loc to make sure i…

0ad02c7

…t fits


          added more loc and loc fixes

ca2fadd

sejtalk requested a review from a team as a code owner

March 25, 2021 14:26


          reversed this change since you can now open ulduar(GDC)

6d4606d

sejtalk changed the title ~~Opening of Ulduar(WIP)~~ Opening of Ulduar

sejtalk requested review from a team

March 25, 2021 14:57

sejtalk self-assigned this

sejtalk added this to the Patch 1.11 milestone

sejtalk added 🎨 2D graphics 🖌️ ❕ priority medium ⭐ new feature 🆕 labels

LordSilvermane reviewed

View reviewed changes

Contributor

LordSilvermane left a comment

Some suggested loc fixes.

localisation/00_wc_sad.csv Outdated Show resolved Hide resolved

localisation/00_wc_sad.csv Outdated Show resolved Hide resolved

localisation/00_wc_sad.csv Outdated Show resolved Hide resolved

localisation/00_wc_sad.csv Outdated Show resolved Hide resolved

localisation/00_wc_sad.csv Outdated Show resolved Hide resolved

LordSilvermane approved these changes

View reviewed changes

Contributor

LordSilvermane left a comment •

edited

Loading

Event chain works fine, just the localization that needs work.


          added german translation and suggested changes to english loc.

ccfaeed

arithon approved these changes

View reviewed changes

Contributor

arithon left a comment

loc LGTM

sejtalk requested a review from MemeWizard

April 24, 2021 15:16

Contributor

MemeWizard commented Apr 24, 2021

Looks like something is wrong with triggers - you can declare war on Ulduar before it was opened.

Click to expand


          you can no longer declare war on ulduar

c6cd034

Contributor Author

sejtalk commented Apr 26, 2021

Looks like something is wrong with triggers - you can declare war on Ulduar before it was opened.

Click to expand

fixed

MemeWizard reviewed

View reviewed changes

common/scripted_triggers/wc_scripted_triggers.txt Outdated Show resolved Hide resolved

events/wc_titanforged_events.txt Outdated Show resolved Hide resolved

decisions/wc_realm_decisions.txt Show resolved Hide resolved

events/wc_titanforged_events.txt Outdated Show resolved Hide resolved

common/scripted_triggers/wc_scripted_triggers.txt Outdated Show resolved Hide resolved

events/wc_titanforged_events.txt Outdated Show resolved Hide resolved

sejtalk added 8 commits

May 20, 2021 16:51


          Merge branch 'master' into opening-of-ulduar

cf85697


          fixed bug that blocked declaring war

2db434e


          event can no longer pick a player

449dba1


          added ai = no pretrigger to open_ulduar decision

9b27148


          characters following evil religion will only hire brann if he has sam…

14bbe5f

…e religion


          making event death proof wip

28d9220


          Merge branch 'master' into opening-of-ulduar

7db149d


          fixed opening of ulduar event

sejtalk requested a review from MemeWizard

July 16, 2021 15:11

MemeWizard reviewed

View reviewed changes

events/wc_titanforged_events.txt Outdated Show resolved Hide resolved


          ulduar explorer doesnt get effect if dead

sejtalk requested a review from MemeWizard

July 22, 2021 13:24

MemeWizard approved these changes

View reviewed changes

events/wc_titanforged_events.txt Outdated Show resolved Hide resolved

common/scripted_triggers/wc_scripted_triggers.txt Outdated Show resolved Hide resolved

events/wc_titanforged_events.txt Outdated Show resolved Hide resolved


          added memewizard suggestions(GDC)

018f752

sejtalk merged commit 9b91ce3 into master

sejtalk deleted the opening-of-ulduar branch

July 22, 2021 21:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 2D graphics 🖌️ ❕ priority medium ⭐ new feature 🆕