Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horse names and localisation #991

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Horse names and localisation #991

wants to merge 2 commits into from

Conversation

SFP-NMOK
Copy link

@SFP-NMOK SFP-NMOK commented Jan 1, 2023

Changed 'horse' to 'mount', to make it more culturally open, and added names of historical mounts / beasts.

Changelog:

  • 'Horse' in horse event now mount to make it more accessible to different races
  • Changed horse list name to include mounts of famous characters and acquirable mounts from WoW

Developer changelog:

  • Removed localisation for mount gender and mare/stallion, now gender neutral 'mounts'.
  • Removed cultural triggers for mount names; all players will see all mount names.

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

Run event 'warhorse.0001'

@SFP-NMOK
Horse names and localisation
777b047 
Changed 'horse' to 'mount', to make it more culturally open, and added names of historical mounts / beasts.
@SFP-NMOK SFP-NMOK linked an issue Jan 1, 2023 that may be closed by this pull request
Horse event adaptation #959
Open
@SFP-NMOK SFP-NMOK self-assigned this Jan 1, 2023
@SFP-NMOK SFP-NMOK requested a review from Gaben1025 January 14, 2023 19:58
@arithon arithon added the localisation 📄 This issue or pull request supposes localization changes label Mar 5, 2023
Gaben1025
Gaben1025 reviewed Apr 25, 2023
View reviewed changes
common/customizable_localization/00_martial_lifestyle_custom_loc.txt
@@ -303,190 +303,190 @@ WarhorseStoryName = {
trigger = {
any_owned_story = {
Copy link
Contributor

@Gaben1025 Gaben1025 Apr 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial event localization isn't fully done, and one option mentions the word horse
image

First choice: Mentions "horse" and mentions some non-warcraft descriptions of names like Caligula
image

Second choice: Some options go off the screen and are unclickable.
image

Third choice: Aside from the option having horse in the name like mentioned above, it is also in the description text
image

Gaben1025
Gaben1025 requested changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@Gaben1025 Gaben1025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the localization and your good

@arithon arithon requested a review from a team April 27, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gaben1025 Gaben1025 Gaben1025 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@SFP-NMOK SFP-NMOK

Labels
localisation 📄 This issue or pull request supposes localization changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Horse event adaptation
3 participants
@SFP-NMOK @Gaben1025 @arithon