Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

High Elf Markings #558

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

High Elf Markings #558

wants to merge 8 commits into from

Conversation

ercarp
Copy link
Contributor

@ercarp ercarp commented Jul 27, 2021 •
edited by zumbak04
Loading

Changelog:

  • Added 6 facial markings to be used by Knights and Commanders with the Quel'dorei culture and High Elf trait.
    • This includes 4 unique markings, including left and right variations of markings 02 and 03.

To-do:

  • Marking facial_highelf_markings_04 is only to be used by clean-shaven male characters.
  • Fix the issue with trait = creature_high_elf not working.
  • Create facial_highelf_markings_05.
  • Create facial_highelf_markings_06.

Known issues:

  • The trait = creature_high_elf part of the modifier does not seem to work. Perhaps it needs to be changed to has_trait instead.

@ercarp ercarp requested a review from zumbak04 July 27, 2021 17:25
@ercarp ercarp self-assigned this Jul 27, 2021
@ercarp ercarp marked this pull request as draft July 27, 2021 17:25
@ercarp ercarp added 2D graphics 🖌️ Involves tweaking/adding 2D arts character designing 😶 Involves tweaking DNAs or either ethnicities or charactes lore 📚 Comes from lore new feature ⭐ Involves adding new feature that affects game WIP 🚧 labels Jul 27, 2021
@ercarp ercarp linked an issue Jul 27, 2021 that may be closed by this pull request
Facial Markings for High Elf Knights/Commanders #554
Open
@zumbak04
Copy link
Member

  • The trait = creature_high_elf part of the modifier does not seem to work. Perhaps it needs to be changed to has_trait instead.

Yes, this is an issue though we define clothes by culture (since a high elf doesn't have to have the high elven culture).

zumbak04 added 3 commits July 28, 2021 00:13
@zumbak04
Commented and Empty
77f5fad 
It shouldn't be empty because the player may set markings in the Ruler Designer.
Deleted commented code.
@zumbak04
Used Triggers
d66b299 
Used clothing scripted triggers instead.
@zumbak04
facial_highelf_markings_04 No Beard
58084c5 
Be default, facial_highelf_markings_04 is never used with beard.
zumbak04
zumbak04 requested changes Jul 27, 2021
View reviewed changes
common/genes/wc_gene_facial_markings.txt
@@ -440,6 +440,149 @@
boy = male
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localized markings in the Ruler Designer and Barbershop.

Click to expand

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zumbak04 zumbak04 zumbak04 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@ercarp ercarp

Labels
2D graphics 🖌️ Involves tweaking/adding 2D arts character designing 😶 Involves tweaking DNAs or either ethnicities or charactes lore 📚 Comes from lore new feature ⭐ Involves adding new feature that affects game WIP 🚧
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facial Markings for High Elf Knights/Commanders
2 participants
@ercarp @zumbak04