Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Night Elf Markings Event #267

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Night Elf Markings Event #267

wants to merge 7 commits into from

Conversation

ercarp
Copy link
Contributor

@ercarp ercarp commented Mar 31, 2021 •
edited by zumbak04
Loading

Changelog:

  • Added a custom event (WCNELF.1) for choosing facial markings as a Female Night Elf with the Elunic religion.
  • Added a custom decision to choose facial markings as a Female Night Elf with the Elunic religion that is 16 years of age or older.
  • Each marking has a character modifier attached to it (technically it's the other way around, but you know what I mean) which applies some stats. These are mostly placeholder and need to be adjusted for balance.

Known issues:

  • Currently, non-ruler AI does not use the decision to choose facial markings. If this cannot be fixed, we need to think of a different way to handle the acquisition of facial markings for non-rulers.
  • The decision is currently linked to religion rather than race or culture, so anyone with the Elunic religion can have the markings even if they're a human or a troll. This might not be an issue depending on how you look at it.
  • All localization is WIP, I just added some basic stuff so it's more readable!

How to test:

To test the event and modifiers:

  1. Pick any character on the map and type event WCNELF.1 in the console to trigger the event.

To test the decision:

  1. Create an Elunic religion character that is aged 16 or older and access the markings event from your Minor Decisions menu.

@ercarp
WIP Facial Markings Event + Decision
6809e01 
- Added a very rudimentary event and decision for assigning facial markings.
- Still needs a lot of work for it to work properly.
@ercarp ercarp added WIP 🚧 new feature ⭐ Involves adding new feature that affects game labels Mar 31, 2021
@ercarp ercarp marked this pull request as draft March 31, 2021 07:11
@ercarp ercarp self-assigned this Mar 31, 2021
@ercarp ercarp requested a review from zumbak04 March 31, 2021 07:12
TheGroxEmpire
TheGroxEmpire reviewed Mar 31, 2021
View reviewed changes
Copy link
Contributor

@TheGroxEmpire TheGroxEmpire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Redacted] Wrong branch

@zumbak04 zumbak04 changed the base branch from master to nightelf-markings March 31, 2021 14:41
zumbak04
zumbak04 requested changes Mar 31, 2021
View reviewed changes
common/decisions/wc_minor_decisions.txt Outdated Show resolved Hide resolved
common/decisions/wc_minor_decisions.txt Show resolved Hide resolved
common/decisions/wc_minor_decisions.txt Outdated Show resolved Hide resolved
common/on_action/childhood_on_actions.txt Outdated Show resolved Hide resolved
events/wc_events/wc_night_elf_events.txt Outdated Show resolved Hide resolved
common/modifiers/wc_night_elf_modifiers.txt
Comment on lines +6 to +7
martial = 3
learning = 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just attribute bonuses look boring. Check for more modifiers:
https://ck3.paradoxwikis.com/Modifier_list
Also, we have the balance spreadsheet. I've added your first marking as an example.
https://docs.google.com/spreadsheets/d/18zS-FAte6nsejx7rpzSmVuioRXps3iWSvSkx_xRJSWI/edit#gid=1390852137&range=A43:A46

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on balancing these right now and changing some of the modifiers to be more interesting.

ercarp and others added 4 commits April 2, 2021 12:02
@ercarp @zumbak04
Update common/decisions/wc_minor_decisions.txt
7cc6b4e 
Co-authored-by: zumbak04 <[email protected]>
@ercarp
Fixes
cde2b61 
- Got rid of on_16th_birthday_night_elf and moved WCNELF.1 to on_16th_birthday.
- Modified has_elunes_marks_trigger so that it fires properly now.
@ercarp
Minor Decision Fix
f83cdc7 
- Changed the is_shown conditions on the Markings Decision to has_elunes_marks_trigger.
- Kept "age >= 16" since we removed is_adult from the trigger.
@ercarp
Remove Markings Effect
6816d80 
- Markings are now removed via a hidden effect instead of cluttering up the event with a million lines of code saying the same thing.
@ercarp ercarp requested a review from a team April 22, 2021 03:15
@zumbak04 zumbak04 removed the request for review from a team May 31, 2021 15:42
Base automatically changed from nightelf-markings to master July 9, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheGroxEmpire TheGroxEmpire TheGroxEmpire left review comments

@zumbak04 zumbak04 zumbak04 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@ercarp ercarp

Labels
new feature ⭐ Involves adding new feature that affects game WIP 🚧
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ercarp @zumbak04 @TheGroxEmpire