Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Crystal #1613

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Dark Crystal #1613

wants to merge 3 commits into from

Conversation

socratespandagoa
Copy link

Changelog:

  • Added wc_historical_artifacts events to create and add the dark_crystal

Developer changelog:

  • Added wc_historical_artifacts.0200 and .0201
  • Added wc_historical_artifacts.0200 to on_combat_actions
  • .0200 triggers on victory against an orcish fel army with caster_unit MAA
  • .0201 creates the dark_crystal artifact and asks the player what to do with it

Tests:

  • Defeat a corruptist army that has caster MAAs
  • Make sure the player gets the dark crystal
  • Make sure the "mysterious" character joins your court
  • Search for throw cases where the player isn't holy_light

How to test: Start as Stormwind in the first bookmark starting date and defeat a corruptist army with an MAA. "event wc_historical_artifacts.0201" in the console command triggers the event quicker testing.

Adds a combat event triggered on victory versus Orcish Fel army with caster_unit MAA (historical_artifacts.200). This event triggers a second one (201) that generates the Dark Crystal.
Removed Ashbringer files and code to more safely test Dark Crystal
Took out the empty trigger block from wc_historical_artifacts.0201, and added scope: to realm_priest on line 84 as ELMariuso suggested
@ElMariuso ElMariuso changed the title Feat/mixed/dark crystal Dark Crystal Dec 18, 2024
target = scope:realm_priest
}
}
add_piety = 500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ai_chance for the ai

}
}
root = {
add_courtier = scope:dark_magic_consultant_2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if you have a title

animation = war_over_win
}

right_portrait = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will look better with lover_left_portrait

Also:

artifact = {
	target = scope:dark_crystal
	position = lower_center_portrait
}

will look good probably

l_english:

wc_historical_artifacts.0201.title:0 "A Warlock's Weapon"
wc_historical_artifacts.0201.desc:0 "At last, after a fierce battle, the corpse of the orc warlock lies on the ground admist our fallen. His weapon, a dark crystal, rests in his palm, emitting a sinister glow.\n\nAs I approach, a shiver runs down my spine. My gaze is locked on the artifact, drawn in by its hypnotic glow. It whispers at the edge of my mind, calling out to me. I bend down and reach for it. The instant my fingers brush the crystal, a searing pain shoots through me.\n\n"Aargh! What sorcery is this?!" I shout as I drop the crystal."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can refer the artifact in the localization with:

[dark_crystal.GetName] instead of just "dark crystal"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants