-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapts Cagots to Murlocs #1574
base: dev
Are you sure you want to change the base?
Adapts Cagots to Murlocs #1574
Conversation
NOT = { | ||
OR = { | ||
culture = murloc | ||
culture = gorloc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to do
culture = { has_cultural_pillar = heritage_amphibian }
incase more murloc-like cultures are added or a custom culture
} | ||
animation = worry | ||
} | ||
triggered_animation = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need to do a triggerd animation, just animation = is fine if it has no trigger
} | ||
|
||
immediate = { | ||
set_variable = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't do this, instead make a really long cooldown, like 100 years, so remove this block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just look at comments, otherwise did a good job
|
||
trigger = { | ||
is_ai = no | ||
NOT = { exists = var:had_cagot_event } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove NOT = { exists = var:had_cagot_event }
animation = disapproval | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add cooldown = { years = 100 }
Changelog:
Developer changelog:
It's a yearly event that triggers on non-tribal coastal counties of your religion, not in northrend, not murlocs or gorlocs with low enough fort level (<8) that has an empty building slot
Event gives options for instant gold+piety and different county modifiers with an conditional choice for lunatic rulers
Tests:
wc
files inDocuments\Paradox Interactive\Crusader Kings III\logs\error.log
exceptportrait_decals.cpp:101
How to test:
100 = yearly.3061 #Murlocs on the shores
line incommon/on_action/yearly_on_actions.txt
to3000 = yearly.3061 #Murlocs on the shores