Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arcane portal ritual #1458

Merged
merged 25 commits into from
Jan 2, 2025
Merged

Arcane portal ritual #1458

merged 25 commits into from
Jan 2, 2025

Conversation

helloruhe
Copy link
Contributor

@helloruhe helloruhe commented Sep 16, 2024

Changelog:

  • Add Arcane Portal Ritual
    • Rank 1: Teleport a target to specific location
    • Rank 2: Teleport multiple characters
    • Rank 3: Teleport an army + commander
  • Todo:
    • Add ability to cast even when other rituals are on cooldown
    • Teleport travel entourages
    • Can't teleport army in combat tooltip
    • Army battle warning tooltip
    • Add decision / event to come back to title location

Developer changelog:

  • This ritual does not trigger the cooldown of other rituals
  • The general ritual cooldown has been shortened

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

@helloruhe helloruhe self-assigned this Sep 16, 2024
@helloruhe helloruhe added the magic ✨ Involves the magic system label Sep 16, 2024
@helloruhe helloruhe changed the title Arcane portal ritual redux Arcane portal ritual Dec 31, 2024
@helloruhe helloruhe marked this pull request as ready for review December 31, 2024 07:22
@FelModder
Copy link

✅: Working as Intended
❌: Not Working as intended
🟡: Practically working but has bugs/issues Working

Arcane Portal Ritual
❌ Rank 1: Teleport a target to specific location
(i casted it on my neighbouring character and then used switch character to switch to the victim to see if it works)
Reasons: The effect of the spell told me that it would take atleast 6 months before i could use the decision but i could use it immediately. (Also, is this really a debuff? the character doesn't really go to the destination because it doesn't avail me a travel decision to go back to my land. That's where the true debuff of the spell lies in my opinion. Basically, no option of teleport travel entourage that you have listed above in "Todo" list.)
Arcane Portal Rank 1

❌ Rank 2: Teleport multiple characters (wtf is that UI lmao, Screenshot no. 1)
Reasons: Just not letting me cast it despite none of the selected characters being in combat/battle. Yes, the destination has been properly selected. (Screenshot no. 2)
Arcane Portal Ritual Rank 2
Arcane Portal Ritual Rank 2 not working

✅ Rank 3: Teleport an army + commander
(Working as intended) (The AI just gives up trying to bring their army back home and just lets the teleported army stay where they are, may need fixing but not necessary right now)

@helloruhe helloruhe merged commit 7ecd9b6 into magic-2024 Jan 2, 2025
1 check failed
@helloruhe helloruhe deleted the arcane-portal-ritual-redux branch January 2, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
magic ✨ Involves the magic system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants