Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic 2024 #1257

Draft
wants to merge 974 commits into
base: dev
Choose a base branch
from
Draft

Magic 2024 #1257

wants to merge 974 commits into from

Conversation

sumankun
Copy link
Contributor

@sumankun sumankun commented Nov 28, 2023 •
edited by helloruhe
Loading

copied description form Meme PR. Updated to the most current patch

Changelog:

  • Added Magic Lifestyles.
  • Added effects to sorcerer traits
  • Changed localisation for magical doctrine parameters
  • Close Class adaptation #5

General TODO:

  • Restrict focus selection
  • Gender doctrine loc
  • Focus buffs / loc
  • Adapt vanilla events
  • Restrict lifestyle selection
  • Give magic resistance even if magic usage is secret
  • Fix Freezerburn perk that Dione broke
  • Fix chances for army/knight targeting spells (currently one roll for entire army, should be one roll per target)
  • Fix spell reflect for new schemes
  • Apply Divine Storm to armies and travelers passing through the area
  • Banshee, Ghoul, Vampire, Revenant trait modifiers and balancing
  • Epidemic traits balancing
  • Epidemic modifiers
  • Fix dodging, hit, and resist TTs
  • Fix add or increase burn/frostbite
  • River Spirit's Rage cultural localization
  • Cancel spell cast when all targets die
  • Notification when spell is off cooldown
  • Fix court mage + integrate with new court position system
  • Add magic modifiers to existing artifacts
  • Add magic event options / modifiers to exisitng WC content
  • Make sure all magic illnesses / injuries use vanilla treatment system

Art TODO:

  • Magic decision backgrounds
  • Fire ritual icons
  • Frostbite decal
  • Frostbite trait icon
  • Ice Block trait icon
  • Frost/snowflake modifier icon
  • Ice block static model
  • Master Pyromancer trait icon
  • Master Cryomancer trait icon
  • Polymorph trait icon
  • Arcane ritual icons
  • Light ritual icons
  • Abomination 3D static model
  • Banshee appearance
  • Ghoul 3D static model
  • Vampire appearance
  • Vampire trait icon
  • Revenant trait icon
  • Frost Fever trait icon
  • Crypt Fever trait icon
  • Blood Plague trait icon
  • Death ritual icons
  • Water ritual icons
  • Hibernation trait icon

Lifestyles TODO:

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log

How to test:

  • Basically, it's 2nd round of what have been tested in Magic doctrines #120 - check that lore character can pick correct focuses in correct lifestyles.
  • Ignore perks, they are not ready yet.
  • Use add_lifestyle_xp_all console command to get exp for all lifestyles

MemeWizard and others added 23 commits July 9, 2022 23:49
@MemeWizard
Update wc_magic_values.txt
8e9fcdf 
GDC
@MemeWizard
Update wc_game_concepts_magic_l_english.yml
eb4908d 
GDC
@MemeWizard
replaced trigger with flag
bd603b9 
GDC
@MemeWizard
Update wc_lifestyle_traits.txt
e53c4f1 
GDC
@MemeWizard
more max mana at higher levels
cff420a 
GDC
@MemeWizard
Merge branch '1.5.0-cultural-traditions' into PRbaseformagicmerge-1.5
cb2cfaf 
# Conflicts:
#	common/on_action/yearly_on_actions.txt
#	common/scripted_effects/wc_vanilla_effects.txt
#	common/scripted_triggers/wc_magic_triggers.txt
#	gui/hud.gui
#	history/characters/120000_nraqi.txt
#	history/characters/240000_qiraji.txt
#	history/characters/450000_sayaadi.txt
#	history/characters/60000_63000_lordaeronian.txt
#	localization/english/wc_game_rules_l_english.yml
#	localization/replace/english/wc_game_concepts_l_english.yml
@MemeWizard
Merge branch 'PRbaseformagicmerge-1.5' into magic-1-5-0-merge
bcdcf2b 
# Conflicts:
#	gui/hud.gui
@MemeWizard
Update wc_magic_doctrines_l_english.yml
725da7a 
GDC
@MemeWizard
Merge pull request #787 from Warcraft-GoA-Development-Team/magic-tree…
4698a19 
…s-new-doctrines-adaptation

Magic trees new doctrines adaptation
@MemeWizard
Merge pull request #809 from Warcraft-GoA-Development-Team/top-to-bot…
1af653b 
…tom-trees

Small magic improvements
@MemeWizard
Merge branch 'master' into PRbaseformagicmerge-1.5
28a53c8 
# Conflicts:
#	localization/replace/english/wc_game_concepts_l_english.yml
@MemeWizard
Merge branch 'magic_trees' into PRbaseformagicmerge-1.5
156c4c7
@MemeWizard
Merge branch 'PRbaseformagicmerge-1.5' into magic-1-5-0-merge
a4dc01f
@sumankun
Merge branch 'master' into magic-2024
4e3cad2
@sumankun
error.log
3fcbfe6
@sumankun
improved gui
19b77fc
@sumankun
error.log
1be20eb
@sumankun
gui fix
fa35695
@Grekopithikos
Merge branch 'master' into magic-2024
a7199c2
@Grekopithikos
physical lifestyle modifiers
c82840b
@Grekopithikos
Merge branch 'master' into magic-2024
0ae8904
@Grekopithikos
Update wc_lifestyle_traits.txt
9120d36
@edmund-h
remove physical tree ( per @ElMariuso )
49da707
helloruhe added 30 commits January 1, 2025 00:07
@helloruhe
move satisfy_spell_triggers to all_requirements_for_casting_satisfied…
2c32e35 
…_trigger
@helloruhe
move tab buttons up top
d442291
@helloruhe
Add targets tab
64d98e9
@helloruhe
new way to select spell class
9a1f3dc
@helloruhe
Move effects tab part 1
ada7f31
@helloruhe
Add caster portraits
2582536
@helloruhe
Choose single target sgui moved
5345282
@helloruhe
Single target army and title info moved
69c12ab
@helloruhe
mutli-target info
0ad21e0
@helloruhe
Remove old effects tab
f8ce636
@helloruhe
Small QoL Fixes
34ef0bb
@helloruhe
clear targets when selecting new spell only
c3a3e9a
@helloruhe
reccomended target selection
f6e75af
@helloruhe
Find more targets using char finder
0ae81b9
@helloruhe
Eligible only toggle
662b598
@helloruhe
add yourself to rec target list
badc54a
@helloruhe
more reccomended target fixes
1836449
@helloruhe
Close province window when choosing new spell/class/target
a658f26
@helloruhe
more eligible target improvements
71a7a33
@helloruhe
cap magical prowess reduction
80a50c9
@helloruhe
make class selection prettier
a68ce23
@helloruhe
Change spell selection GUI
688a288
@helloruhe
Change character selection box
5005ec2
@helloruhe
fix eligible for armies
c99c382
@helloruhe
make "open spellbook" button actually open spellbook
6b00172
@helloruhe
make open spellbook button a bit bigger
8e83968
@helloruhe
Small QoL fixes
adc2937
@helloruhe
Arcane portal ritual (#1458)
7ecd9b6 
* Create portal exempt to ritual cooldown

* Create Portal Initial commit

* add gui for multiple character targets

* Add ability to select destination

* add cascading portal selection

* add empires to list first

* pan_camera_to_title when target is selected

* add tooltip for characters

* fix change destination gui clipping

* army tooltips

* fix error spam

* fix 'type' error

* fix recipient error

* remove loose variables

* add travel entourage functionality

* add tooltips to prevent people from breaking shit

* Fix army tootlip

* add tooltips/disable teleporting when army in combat

* Fix army teleportation

* Fix pt 2

* Add decision to go back home

* Remove isolated titles and titles with no barony

* fix2
@helloruhe
Merge branch 'magic-2024' into feat/code/magic-gui-overhaul
500f6d5
@helloruhe
Fix create portal
e2ac536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helloruhe helloruhe helloruhe left review comments

@robmart robmart robmart left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@robmart robmart

@edmund-h edmund-h

@helloruhe helloruhe

Labels
new feature ⭐ Involves adding new feature that affects game
Projects
None yet
Milestone
No milestone
7 participants
@sumankun @robmart @helloruhe @edmund-h @Grekopithikos @MemeWizard @Myphicbowser