Improvements

WapplerSystems · Oct 27, 2024 · ebf1a94 · ebf1a94
1 parent e4ea7f5
commit ebf1a94
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/Classes/Authentication/KeyAuthenticationProvider.php b/Classes/Authentication/KeyAuthenticationProvider.php
@@ -19,11 +19,11 @@ class KeyAuthenticationProvider
      * @param $key
      * @return bool
      */
-    public function hasValidKey($key)
+    public function hasValidKey($key): bool
     {
         $config = Configuration::getExtConfiguration();
         return trim($config['apiKey']) === trim($key);
     }
 
 
-}
+}
diff --git a/Classes/Middleware/ZabbixClient.php b/Classes/Middleware/ZabbixClient.php
@@ -69,7 +69,7 @@ private function processRequest(ServerRequestInterface $request)
             return $response->withStatus(403, 'Not allowed');
         }
 
-        $key = $request->getParsedBody()['key'] ?? $request->getQueryParams()['key'] ?? null;
+        $key = $request->getParsedBody()['key'] ?? $request->getQueryParams()['key'] ?? '';
         $keyAuthenticationProvider = new KeyAuthenticationProvider();
         if (!$keyAuthenticationProvider->hasValidKey($key)) {
             /** @var Response $response */
@@ -89,7 +89,7 @@ private function processRequest(ServerRequestInterface $request)
         $GLOBALS['TYPO3_REQUEST'] = (new ServerRequest())->withAttribute(
             'applicationType',
             SystemEnvironmentBuilder::REQUESTTYPE_BE
-        )->withAttribute('frontend.typoscript',new FrontendTypoScript(new RootNode(),[]));
+        )->withAttribute('frontend.typoscript',new FrontendTypoScript(new RootNode(),[],[],[]));
 
         if ($operation !== null && $operation !== '') {
             try {

diff --git a/Classes/Operation/HasForbiddenUsers.php b/Classes/Operation/HasForbiddenUsers.php
@@ -9,6 +9,7 @@
  * LICENSE.txt file that was distributed with this source code.
  */
 
+use Doctrine\DBAL\Exception;
 use TYPO3\CMS\Core\Database\ConnectionPool;
 use TYPO3\CMS\Core\Database\Query\QueryBuilder;
 use TYPO3\CMS\Core\SingletonInterface;
@@ -29,6 +30,7 @@ class HasForbiddenUsers implements IOperation, SingletonInterface
      *
      * @param array $parameter None
      * @return OperationResult
+     * @throws Exception
      */
     public function execute(array $parameter = []): OperationResult
     {