!!![BUGFIX] Fix for sql_mode=only_full_group_by #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In newer MySQL versions the query in GlossaryRepository::findAllForIndex() will fail if sql_mode contains only_full_group_by. The problem is the ORDER BY clause which does not match the GROUP BY. This patch replaces the Extbase query entirely with Doctrine-dbal functionality. The use of language fetching via getAspect() will not work for TYPO3 previous to 9.5 Resolves: WapplerSystems#10
sypets
force-pushed
the
sypets/fix-for-only_full_group_by-WITH-QB
branch
from
63bd3df to
5172ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In newer MySQL versions the query in GlossaryRepository::findAllForIndex()
will fail if sql_mode contains only_full_group_by.
The problem is the ORDER BY clause which does not match the GROUP BY.
This patch replaces the Extbase query entirely with Doctrine-dbal
functionality.
The use of language fetching via getAspect() will not work for TYPO3
previous to 9.5
Resolves: #10