-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: v2 migration Cloudflare KV #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to fix any of this, just for the future
Liking the composability of the abstractions already? 😄
#[derive(Clone)] | ||
pub struct CloudflareKv { | ||
pub endpoint: Url, | ||
pub token_manager: TokenManager, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
attestation_store
-> http_server
dependency really stinks, but oh well it's going to be deprecated anyway 😄
Actually they constrained what I wanted to implement: I wanted to call the regular get attestation endpoint from the worker, but this did an additional lookup on the data lake API which would've added latency and be redundant with the lookup that's being done here. If the abstraction wasn't so strong it probably would've been easier to use the response from the worker exclusively and disable the redundant lookup here. Instead I made a new endpoint on the worker that didn't do the data lake call so that it would fit into the AttestationStore abstraction. |
Description
Prepares for the Verify Server V2 migration by mirroring all attestation writes to Cloudflare KV. Also reads attestations from Cloudflare KV if not found in Redis.
Remaining work:
TestsAlready covered by integration tests + tested manuallyHow Has This Been Tested?
Due Diligence