generated from WalletConnect/rust-http-starter
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to dedicated AWS account and update CI #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xav
force-pushed
the
58-migrate-ti-dedicated-aws-account
branch
from
February 2, 2024 14:32
dfa1c6f
to
ec0dfbc
Compare
xav
force-pushed
the
58-migrate-ti-dedicated-aws-account
branch
from
February 2, 2024 15:39
e0e253c
to
2e4afff
Compare
xav
force-pushed
the
58-migrate-ti-dedicated-aws-account
branch
from
February 2, 2024 15:52
2e4afff
to
887199b
Compare
xav
requested review from
xDarksome and
arein
and removed request for
xDarksome
February 4, 2024 17:38
arein
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just out of extra caution: please add on statuspage and let's confirm metrics/alarms afterwards
xDarksome
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, assuming:
- CI/CD actions are tested
- integration tests pass
- analytics export works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate to the dedicated AWS account and switch CI to the shared flows
Resolves # (issue)
How Has This Been Tested?
Deployed manually
Due Diligence