-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
Addresses: #16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, interesting that code coverage decreased.
Perhaps we should exclude the configs?
Approving but we need to fix the CI issues before merging.
@fernando-oktana - Did you by any chance compare the available properties in the KPL & KCL with what we're exposing on our reference.conf? I can close the related issues is so, otherwise I'll raise an issue so we don't forget. I want to make sure that no other new ones have been added that we missed
@markglh Thanks! @fernando-oktana - Did you by any chance compare the available properties in the KPL & KCL with what we're exposing on our reference.conf? I can close the related issues is so, otherwise I'll raise an issue so we don't forget. I want to make sure that no other new ones have been added that we missed
KCL: TODO |
KCL
|
1 similar comment
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks!
Add configs and test related to @markglh 's comments:
#15