Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: basic dependency bump #485

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

JoblersTune
Copy link
Collaborator

There have been a few difficulties with this dependency bump.

Firstly, Starlight, as of now, has a compatibility issue with astro@5. This is being addressed (see withastro/starlight#2612)

Secondly, bumping up the @astrojs/starlight dependency caused compatibility issues with the HeadHrefLangs component that is part of the astro-i18next module. Unfortunately, it seems this module is no longer being maintained. As such, I've removed it for now. HeadHrefLangs is a component from astro-i18next that generated tags with hreflang attributes for SEO, specifying alternate language versions of a webpage. This means we need to investigate a new way to build this in and probably use either a different community based plugin for this, or move over to Astro's Built-in i18n Support. This also has limitations which is why it needs more work to figure out the best path.

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for webmonetization-preview ready!

Name Link
🔨 Latest commit 0affbe9
🔍 Latest deploy log https://app.netlify.com/sites/webmonetization-preview/deploys/675bfad1fed42c0008112597
😎 Deploy Preview https://deploy-preview-485--webmonetization-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@huijing huijing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huijing huijing merged commit a1b5f17 into WICG:main Dec 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants