Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updates to readme #426

Merged
merged 1 commit into from
Feb 14, 2024
Merged

docs: updates to readme #426

merged 1 commit into from
Feb 14, 2024

Conversation

melissahenderson
Copy link
Collaborator

@melissahenderson melissahenderson commented Jan 11, 2024

Closes #431

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for webmonetization-preview ready!

Name Link
🔨 Latest commit 08c9ac9
🔍 Latest deploy log https://app.netlify.com/sites/webmonetization-preview/deploys/65a03e7f1b36af0008302ece
😎 Deploy Preview https://deploy-preview-426--webmonetization-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@melissahenderson melissahenderson added the documentation All content related issues. For functionality issues, use the `website` tag label Jan 11, 2024
@melissahenderson
Copy link
Collaborator Author

@huijing Do you mind giving this a look over when you're feeling better? I removed the "Web Monetization Specification" section and would like your opinion on whether that was a good idea. If not, I can add it back.

@huijing
Copy link
Collaborator

huijing commented Jan 15, 2024

I think it's fine to remove, but could we keep those details in a separate MD file maybe?

Update:
I'm going to update this PR to move the bit about specifications into the CONTRIBUTING.md file.

@melissahenderson
Copy link
Collaborator Author

This merge will include fixes for #431

Copy link
Collaborator

@huijing huijing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huijing huijing merged commit d58a8f2 into main Feb 14, 2024
6 checks passed
@huijing huijing deleted the mh-readme branch February 14, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation All content related issues. For functionality issues, use the `website` tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interledger spec links are broken
2 participants