Spec the toArray() operator
#97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benlesh Would you be able to take a look at this and confirm that the semantics look right to you? |
|
I'm trying to see why PR preview isn't working on this PR. Closing and re-opening to see if that triggers it. |
domfarolino
force-pushed
the
toArray-operator
branch
from
cd0305e to
ed150a4
Compare
domenic
reviewed
Jan 10, 2024
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 23, 2024
After the spec discussion in WICG/observable#97 (comment), the remaining Promise-returning operator implementations did not include the active document check that Observer#toArray() originally did, since it was implemented before this discussion took place. This CL simplifiefs `toArray()` by removing the check, since it is not necessary. As a side effect, this will close https://crbug.com/328281225. R=jarhar Bug: 40282760, 328281225 Change-Id: I0e052d36b9e6583adb6a63f47136c96b86547e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5796962 Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1346030}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes spec'ing the
toArray()operator, as a warm-up for the rest.Preview | Diff