Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec to mention rejecting with a new RangeError #179

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Update spec to mention rejecting with a new RangeError #179

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecbbaa5
docs: update spec to mention rejecting with a new RangeError
maraisr Oct 16, 2024
f77730e
chore: remove message spec as per feedback
maraisr Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1523,13 +1523,10 @@ For now, see [https://github.com/wicg/observable#operators](https://github.com/w
:: [=Reject=] |p| with the passed in <var ignore>error</var>.

: [=internal observer/complete steps=]
:: [=Resolve=] |p| with {{undefined}}.
:: [=Reject=] |p| with a new {{RangeError}}, and message of "No values in Observable".
maraisr marked this conversation as resolved.
Show resolved Hide resolved

Note: This is only reached when the source {{Observable}} completes *before* it emits a
single value; in this case, resolving with {{undefined}} is harmless but makes it
difficult to distinguish between the first value trule being {{undefined}} and premature
completion. See <a href=https://github.com/WICG/observable/issues/132>#132</a> for
discussion on this.
single value.

1. <a for=Observable lt="subscribe to an Observable">Subscribe</a> to [=this=] given |internal
observer| and |internal options|.
Expand Down
Loading