Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SubscriptionObserverCallback to ObservableSubscriptionCallback #157

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Rename SubscriptionObserverCallback to ObservableSubscriptionCallback #157

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df8bb3a
rename SubscriptionObserverCallback to ObservableSubscriptionCallback
keithamus Jul 16, 2024
54aa7ac
fix typo
keithamus Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,15 +317,15 @@ observable.subscribe({}, {signal: outerController.signal});
// SubscribeCallback is where the Observable "creator's" code lives. It's
// called when subscribe() is called, to set up a new subscription.
callback SubscribeCallback = undefined (Subscriber subscriber);
callback SubscriptionObserverCallback = undefined (any value);
callback ObservableSubscriptionCallback = undefined (any value);

dictionary SubscriptionObserver {
SubscriptionObserverCallback next;
SubscriptionObserverCallback error;
ObservableSubscriptionCallback next;
ObservableSubscriptionCallback error;
VoidFunction complete;
};

typedef (SubscriptionObserverCallback or SubscriptionObserver) ObserverUnion;
typedef (ObservableSubscriptionCallback or SubscriptionObserver) ObserverUnion;

dictionary SubscribeOptions {
AbortSignal signal;
Expand Down Expand Up @@ -464,7 +464,7 @@ An <dfn>internal observer</dfn> is a [=struct=] with the following [=struct/item
<ol id=process-observer>
<li>
<dl class="switch">
<dt>If |observer| is a {{SubscriptionObserverCallback}}</dt>
<dt>If |observer| is a {{ObservableSubscriptionCallback}}</dt>
keithamus marked this conversation as resolved.
Show resolved Hide resolved
<dd>Set |internal observer|'s [=internal observer/next steps=] to these steps that take
an {{any}} |value|:

Expand Down
Loading