Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec the first() operator #131

Merged
merged 3 commits into from
May 5, 2024
Merged

Spec the first() operator #131

merged 3 commits into from
May 5, 2024

Conversation

domfarolino
Copy link
Collaborator

@domfarolino domfarolino commented Apr 2, 2024 •
edited by pr-preview bot
Loading

Closes #65 and makes progress on #126.

Preview | Diff

@domfarolino domfarolino requested a review from benlesh April 2, 2024 18:41
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 2, 2024
@domfarolino @chromium-wpt-export-bot
DOM: Implement the first() Observable operator
6ee9e6a 
See WICG/observable#131.

For WPTs:
Co-authored-by: [email protected]

[email protected]

Bug: 40282760
Change-Id: I81a2b482dcfdbc149d60ddbc5b98ddadb6dafc89
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Apr 2, 2024
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 3, 2024
@domfarolino @chromium-wpt-export-bot
DOM: Implement the first() Observable operator
1360465 
See WICG/observable#131.

For WPTs:
Co-authored-by: [email protected]

[email protected]

Bug: 40282760
Change-Id: I81a2b482dcfdbc149d60ddbc5b98ddadb6dafc89
aarongable pushed a commit to chromium/chromium that referenced this pull request Apr 3, 2024
@domfarolino
DOM: Implement the first() Observable operator
4b50763 
See WICG/observable#131.

For WPTs:
Co-authored-by: [email protected]

[email protected]

Bug: 40282760
Change-Id: I81a2b482dcfdbc149d60ddbc5b98ddadb6dafc89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5412443
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Dominic Farolino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1281639}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 3, 2024
@domfarolino @chromium-wpt-export-bot
DOM: Implement the first() Observable operator
1e07357 
See WICG/observable#131.

For WPTs:
Co-authored-by: [email protected]

[email protected]

Bug: 40282760
Change-Id: I81a2b482dcfdbc149d60ddbc5b98ddadb6dafc89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5412443
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Dominic Farolino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1281639}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 3, 2024
@domfarolino @chromium-wpt-export-bot
DOM: Implement the first() Observable operator
ce7e878 
See WICG/observable#131.

For WPTs:
Co-authored-by: [email protected]

[email protected]

Bug: 40282760
Change-Id: I81a2b482dcfdbc149d60ddbc5b98ddadb6dafc89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5412443
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Dominic Farolino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1281639}
@domfarolino domfarolino mentioned this pull request Apr 3, 2024
Closed
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 10, 2024
@domfarolino @moz-wptsync-bot
Bug 1889253 [wpt PR 45479] - DOM: Implement the first() Observable …
1ad9268 
…operator, a=testonly

Automatic update from web-platform-tests
DOM: Implement the `first()` Observable operator

See WICG/observable#131.

For WPTs:
Co-authored-by: [email protected]

[email protected]

Bug: 40282760
Change-Id: I81a2b482dcfdbc149d60ddbc5b98ddadb6dafc89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5412443
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Dominic Farolino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1281639}

--

wpt-commits: ce7e87833b6156bb648e9abc944c97b25b3544b5
wpt-pr: 45479
benlesh
benlesh reviewed Apr 10, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
@domfarolino domfarolino requested a review from benlesh April 10, 2024 22:04
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this pull request Apr 15, 2024
@domfarolino @moz-wptsync-bot
Bug 1889253 [wpt PR 45479] - DOM: Implement the first() Observable …
ee39ee8 
…operator, a=testonly

Automatic update from web-platform-tests
DOM: Implement the `first()` Observable operator

See WICG/observable#131.

For WPTs:
Co-authored-by: [email protected]

[email protected]

Bug: 40282760
Change-Id: I81a2b482dcfdbc149d60ddbc5b98ddadb6dafc89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5412443
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Dominic Farolino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1281639}

--

wpt-commits: ce7e87833b6156bb648e9abc944c97b25b3544b5
wpt-pr: 45479
@domfarolino
Copy link
Collaborator Author

@benlesh I'm thinking it would be nice to make first() and last() consistent with find() in the case where an Observable completes before emitting any values. See #137 (comment). What do you think?

This was referenced Apr 30, 2024
Merged
Merged
Open
@domfarolino domfarolino merged commit 7a4c941 into master May 5, 2024
2 checks passed
@domfarolino domfarolino deleted the first-operator branch May 5, 2024 14:43
github-actions bot added a commit that referenced this pull request May 5, 2024
@domfarolino @github-actions
Spec the first() operator (#131)
dc9ec6d 
SHA: 7a4c941
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlesh benlesh benlesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Way for single event subscription?
2 participants
@domfarolino @benlesh