-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove aggregatable report limit when trigger context ID is non-null #1475
Open
giladbarkan-github
wants to merge
4
commits into
WICG:main
Choose a base branch
from
giladbarkan-github:trigger_context_id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove aggregatable report limit when trigger context ID is non-null #1475
giladbarkan-github
wants to merge
4
commits into
WICG:main
from
giladbarkan-github:trigger_context_id
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apasel422
requested review from
csharrison,
vikassahu29,
johnivdel and
akashnadan
December 10, 2024 13:20
vikassahu29
approved these changes
Dec 10, 2024
linnan-github
approved these changes
Dec 11, 2024
Please also update the explainer: https://github.com/WICG/attribution-reporting-api/blob/main/AGGREGATE.md#hide-the-true-number-of-attribution-reports |
Done. |
csharrison
approved these changes
Dec 13, 2024
akashnadan
approved these changes
Dec 13, 2024
arpanah
requested changes
Dec 13, 2024
arpanah
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current hard limit on aggregatable reports per source might be too small for
some use-cases. Allowing consumers to manage report counts that already have
privacy constraints applied provides more flexibility. In the case of this
change, when a trigger context ID is supplied, null report rate already manages
the necessary privacy constraints in place of a hard limit on aggregatable
report count.
(See also #1183)
Preview | Diff