Explainer change for separate rate-limits for embedded site #1457
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jolynyao Could you PTAL, thanks! |
linnan-github
force-pushed
the
embeddedBudget
branch
4 times, most recently
from
5144c38 to
f6c6a38
Compare
|
LGTM thanks @linnan-github! |
apasel422
previously requested changes
Oct 29, 2024
apasel422
reviewed
Oct 29, 2024
linnan-github
force-pushed
the
embeddedBudget
branch
from
29e0579 to
22edc9a
Compare
arpanah
reviewed
Dec 18, 2024
| @@ -33,7 +33,7 @@ The `body` will contain the following fields for all source debugging reports: | |||
| This will be a string if there was one such site, or a list of strings if | |||
| there were multiple. | |||
| * `source_event_id`: The source registration's `source_event_id`. | |||
| * `source_site`: The top-level site on which the source registration occurred. | |||
| * `source_site`: The top-level site, or the embedded site for specific use cases, on which the source registration occurred. | |||
There was a problem hiding this comment.
add (for example, AMP pages rendered by an AMP
cache/viewer provider) here as well
| 1. Return |node|'s [=node navigable=]'s [=navigable/top-level traversable=]'s | ||
| [=navigable/active document=]'s [=origin=]. | ||
|
|
||
| Note: The user agent MAY return the embedded origin to allow separate limits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1452
Preview | Diff