bug fix

WEEE-Open · Sep 24, 2024 · 3f24fe8 · 3f24fe8
1 parent 0bee4bb
commit 3f24fe8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/docker-compose.yml b/docker-compose.yml
@@ -1,5 +1,4 @@
 ---
-version: '3.4'
 services:
   app:
     image: weeehire-ng/app

diff --git a/src/PagePosition.php b/src/PagePosition.php
@@ -53,7 +53,8 @@ public function handle(ServerRequestInterface $request): ResponseInterface
 				// Delete position
 				$db->deletePosition($_GET['id']);
 				return new RedirectResponse('settings.php', 303);
-			} elseif (isset($POST['id'])) {
+			} 
+			if (isset($POST['id'])) {
 				// Update the id of the position
 				// Make sure the id is url safe (aka keep only lowercase letters and dashes) and replace spaces with dashes
 				$newId = preg_replace('/[^a-z-]/', '', preg_replace('/ /', '-', strtolower($POST['id'])));
@@ -66,11 +67,13 @@ public function handle(ServerRequestInterface $request): ResponseInterface
 						return new RedirectResponse('position.php?id=' . $newId, 303);
 					}
 				}
-			} elseif (isset($POST['index'])) {
+			} 
+			if (isset($POST['index'])) {
 				// Update the index of the position
 				$db->updatePositionIndex($_GET['id'], $POST['index']);
 				$changed = true;
-			} elseif (isset($POST['translation'])) {
+			} 
+			if (isset($POST['translation'])) {
 				// Figure out which translation has been changed and update it
 				foreach (Template::SUPPORTED_LOCALES as $locale) {
 					if (isset($POST['name-' . $locale]) && $POST['name-' . $locale] !== $nameTranslations[$locale]) {

diff --git a/src/PageSettings.php b/src/PageSettings.php
@@ -55,8 +55,8 @@ public function handle(ServerRequestInterface $request): ResponseInterface
 				$id = preg_replace('/[^a-z-]/', '', preg_replace('/ /', '-', strtolower($POST['newPositionName'])));
 				$db->addPosition($id);
 				foreach (Template::SUPPORTED_LOCALES as $locale) {
-					$db->updateTranslation('position.' . $id . '.name', $POST['newPositionName'], $locale);
-					$db->updateTranslation('position.' . $id . '.description', '', $locale);
+					$db->updateTranslation('position.' . $id . '.name', $locale, $POST['newPositionName']);
+					$db->updateTranslation('position.' . $id . '.description', $locale, '');
 				} // setting translations to a default string, we'll edit it right after
 				return new RedirectResponse('position.php?id=' . $id, 303);
 			} elseif (isset($POST['notifyEmail'])) {