Fixes to git commands hardening. #720
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to get make_git_command in reach, and keep that command in the scope of installer.vim
|
Thanks, I just haven't gotten around to it yet. Apologies. |
|
No problem :-) |
raja-xone
approved these changes
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested the current release, and it breaks at update time and for changelog generation.
The issue is that you need to be in the git_dir for git to work correctly for submodules, but that you cannot move to the worktree when cloning (because it does not exist yet).
The changelog was broken because make_git_command was not available in that script.
I moved one function around and exported it.
I have now tested my changes within and outside vcsh (GIT_DIR set) for the following operations:
My apologizes for not having properly tested my previous patches.