Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing users of the library to tweak the reqwest client's timeout #245

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

bylerbk
Copy link
Contributor

@bylerbk bylerbk commented Oct 2, 2024

Changes Made

  1. Added reqwest_timeout:
    • Introduced a new field reqwest_timeout in the WebDriverConfig struct to specify the timeout duration for the reqwest client.
    • Updated the WebDriverConfigBuilder to include methods for setting the reqwest_timeout.
    • Ensured that the default timeout is set to 120 seconds if not specified by the user.
  2. Updated web_driver.rs:
    • Modified the new_with_config function to use the reqwest_timeout from the WebDriverConfig when creating the reqwest client

This change enhances the flexibility of the WebDriver by allowing users to configure the timeout for the reqwest client, making the library more adaptable to different use cases.

closes #244

@Vrtgs Vrtgs self-requested a review October 11, 2024 09:51
Vrtgs
Vrtgs previously approved these changes Oct 11, 2024
Copy link
Owner

@Vrtgs Vrtgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vrtgs
Copy link
Owner

Vrtgs commented Oct 11, 2024

Can you fix ci (run cargo fmt)?

@Vrtgs
Copy link
Owner

Vrtgs commented Oct 21, 2024

CI is failing(?)

btw sorry for being late I had midterms coming up and had to cram

@Vrtgs Vrtgs merged commit ef188b9 into Vrtgs:main Oct 21, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Reqwest Timeout Configuration in WebDriverConfig
2 participants