adding vertical scrolling based on fixed visual textInput compared to hiddenInput

[hanbollar]

Linking

related to #590

Problem

Description of the problem including potential code and/or screenshots as an example

Solution

Quick explanation of change to be done

Breaking Change

If this is a breaking change describe the before and after and why the change was necessary

Notes

Notes and any associated research or links

---

Required to Merge

• PASS - all necessary actions must pass (excluding the auto-skipped ones)
• TEST IN HEADSET - main dev-testing-example and any of the other examples still work as expected
• VIDEO - if this pr changes something visually - post a video here of it in headset-MR and/or on desktop (depending on what it affects) for the reviewer to reference.

Untitled.mov

• TITLE - make sure the pr's title is updated appropriately as it will be used to name the commit on merge
  - [ ] BREAKING CHANGE
  • DOCUMENTATION: This includes any changes to html tags and their components
    • make a pr in the documentation repo that updates the manual docs to match the breaking change
    • link the pr of the documentation repo here: #pr
    • that pr must be approved by @lobau
  • SAMPLES/INDEX.HTML: This includes any changes (html tags or otherwise) that must be done to our landing page submodule as an effect of this pr's updates
    • make a pr in the mrjs landing page repo that updates the landing page to match the breaking change
    • link the pr of the landing page repo here: #pr
    • that pr must be approved by @hanbollar

[render]

Your Render PR Server URL is https://examples-mrjs-pr-589.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-coergt21hbls73851ptg.

[hanbollar]

so far on this pr - have some scrolling working by actual key input presses and text update

to fix for vertical happiness:

• text deletion struggles with the update for the change in visual scroll
• cursor movement works until it doesnt
• the special case where startLineIndex and endLineIndex for textObj are the same

in a future pr:

• horizontal scrolling and word wrap

[hanbollar]

so far on this pr - have some scrolling working by actual key input presses and text update

to fix for vertical happiness:

• text deletion struggles with the update for the change in visual scroll
• cursor movement works until it doesnt
• the special case where startLineIndex and endLineIndex for textObj are the same

in a future pr:

• horizontal scrolling and word wrap

progress:

• text deletion struggles with the update for the change in visual scroll
• cursor movement works until it doesnt
• the special case where startLineIndex and endLineIndex for textObj are the same

outstanding todo:

• weird case where doing an input key after doing a cursor movement even though no textobj scroll should happen can shift textObj line display by 1, but only on that first cursor direction after a textobj shift --> prob an off by one error somewhere

[hanbollar]

so far on this pr - have some scrolling working by actual key input presses and text update
to fix for vertical happiness:

• text deletion struggles with the update for the change in visual scroll
• cursor movement works until it doesnt
• the special case where startLineIndex and endLineIndex for textObj are the same

in a future pr:

• horizontal scrolling and word wrap

progress:

• text deletion struggles with the update for the change in visual scroll
• cursor movement works until it doesnt
• the special case where startLineIndex and endLineIndex for textObj are the same

outstanding todo:

• weird case where doing an input key after doing a cursor movement even though no textobj scroll should happen can shift textObj line display by 1, but only on that first cursor direction after a textobj shift --> prob an off by one error somewhere

outstanding todo:

• fix offby one maxendline index being too short only on keypress, but fine on scrolling

[hanbollar]

so far on this pr - have some scrolling working by actual key input presses and text update
to fix for vertical happiness:

• text deletion struggles with the update for the change in visual scroll
• cursor movement works until it doesnt
• the special case where startLineIndex and endLineIndex for textObj are the same

in a future pr:

• horizontal scrolling and word wrap

progress:

• text deletion struggles with the update for the change in visual scroll
• cursor movement works until it doesnt
• the special case where startLineIndex and endLineIndex for textObj are the same

outstanding todo:

• weird case where doing an input key after doing a cursor movement even though no textobj scroll should happen can shift textObj line display by 1, but only on that first cursor direction after a textobj shift --> prob an off by one error somewhere

outstanding todo:

• fix offby one maxendline index being too short only on keypress, but fine on scrolling

• fix offby one maxendline index being too short only on keypress, but fine on scrolling

[hanbollar]

primary task after this pr:

• handle word wrapping and horizontal scrolling nicely - note: textobj partially handles it already, but not always in the best way
• make sure up/down arrows actually hit the end of the line (check the video from the pr header, they might not actually be there when doing up/down cursor only)

a few lingering todos from this pr for cleanup when doing the horizontal scrolling addition:

note these are not dependent on this pr, these are nice-to-have code-cleanups that need to happen before exposure though

• needs to be a cleaner way to lean on js instead of manual for this? (probably a quick fix indexing thing with the full string itself): https://github.com/Volumetrics-io/mrjs/pull/589/files#diff-3d3f16e2d0545a01a3ff9bfbb340883f30f0c3bc1ae63b06c113eb430939a170R444-R446
  • using summation to get substring up to line index: https://github.com/Volumetrics-io/mrjs/pull/589/files#diff-3d3f16e2d0545a01a3ff9bfbb340883f30f0c3bc1ae63b06c113eb430939a170R375-R393
  • using summation to get substring between line indices: https://github.com/Volumetrics-io/mrjs/pull/589/files#diff-3d3f16e2d0545a01a3ff9bfbb340883f30f0c3bc1ae63b06c113eb430939a170R395-R414
• naming - too long
  • https://github.com/Volumetrics-io/mrjs/pull/589/files#diff-3d3f16e2d0545a01a3ff9bfbb340883f30f0c3bc1ae63b06c113eb430939a170R251
  • https://github.com/Volumetrics-io/mrjs/pull/589/files#diff-3d3f16e2d0545a01a3ff9bfbb340883f30f0c3bc1ae63b06c113eb430939a170R265
• check on this /end-line-char/ todo: https://github.com/Volumetrics-io/mrjs/pull/589/files#diff-3d3f16e2d0545a01a3ff9bfbb340883f30f0c3bc1ae63b06c113eb430939a170R428-R429

after:

once all those are resolved then can expose again and start on going down more of 'fully supported' feature list

[hanbollar]

@michaelthatsit - solved the off-by-1 error, this is now ready for review

check out my todo list for notes (doing it written before the review this time instead of answering /oh yea i swear that'll be handled lol/ as part of the review to help with the process a bit)

btw when reading through start with TextInputEntity before looking at TextAreaEntity/TextFieldEntity changes so that the comments make more sense

lmk if any questions ~

[michaelthatsit]

lgtm! and glad you got the lingering cursor issue when switching input fields, forgot to mention it last time.