Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the cursor height and positioning relative to the text and font #588

Merged
merged 9 commits into from
Apr 18, 2024

Conversation

hanbollar
Copy link
Contributor

@hanbollar hanbollar commented Apr 15, 2024

Linking

related to #590

Problem

Screenshot 2024-04-15 at 1 46 01 PM Screenshot 2024-04-15 at 1 46 07 PM

cursor positioning is at top of line with odd bottom offset (due to line height having a bit on top of the text itself so it doesnt exactly match fontsize)

goal:

(this is an inprogress photo - but it shows goal of positioning at proper 'height' in line, though the cursor's own height doesnt yet match the fontsize for the line)

Screenshot 2024-04-15 at 1 47 22 PM

Solution

Quick explanation of change to be done

Breaking Change

If this is a breaking change describe the before and after and why the change was necessary

Notes

  • get cursor's height positioning right in the line
  • get cursor's physical height to match font size <-- remaining todo

Required to Merge

  • PASS - all necessary actions must pass (excluding the auto-skipped ones)
  • TEST IN HEADSET - main dev-testing-example and any of the other examples still work as expected
  • VIDEO - if this pr changes something visually - post a video here of it in headset-MR and/or on desktop (depending on what it affects) for the reviewer to reference.
cursor.mov
  • TITLE - make sure the pr's title is updated appropriately as it will be used to name the commit on merge
    - [ ] BREAKING CHANGE
    • DOCUMENTATION: This includes any changes to html tags and their components
      • make a pr in the documentation repo that updates the manual docs to match the breaking change
      • link the pr of the documentation repo here: #pr
      • that pr must be approved by @lobau
    • SAMPLES/INDEX.HTML: This includes any changes (html tags or otherwise) that must be done to our landing page submodule as an effect of this pr's updates
      • make a pr in the mrjs landing page repo that updates the landing page to match the breaking change
      • link the pr of the landing page repo here: #pr
      • that pr must be approved by @hanbollar

Copy link

render bot commented Apr 15, 2024

Signed-off-by: hanbollar <[email protected]>
@hanbollar hanbollar mentioned this pull request Apr 15, 2024
29 tasks
@hanbollar hanbollar changed the title WIP - Fix for the cursor height and positioning relative to the text and font Fix for the cursor height and positioning relative to the text and font Apr 17, 2024
Signed-off-by: hanbollar <[email protected]>
Signed-off-by: hanbollar <[email protected]>
Signed-off-by: hanbollar <[email protected]>
Signed-off-by: hanbollar <[email protected]>
@hanbollar hanbollar merged commit 0ae2e38 into main Apr 18, 2024
6 checks passed
@hanbollar hanbollar deleted the hb-cursor-pos branch April 18, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants