fix: fix issue with image stroke clip

VisActor · Jan 2, 2025 · 683dbe2 · 683dbe2
1 parent fc7d7d1
commit 683dbe2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 33 deletions.
diff --git a/packages/vrender-core/src/render/contributions/render/image-render.ts b/packages/vrender-core/src/render/contributions/render/image-render.ts
@@ -109,26 +109,6 @@ export class DefaultCanvasImageRender extends BaseRender<IImage> implements IGra
         if (fillCb) {
           fillCb(context, image.attribute, imageAttribute);
         } else if (fVisible) {
-          if (!url || !image.resources) {
-            return;
-          }
-          const res = image.resources.get(url);
-          if (res.state !== 'success') {
-            return;
-          }
-
-          // deal with cornerRadius
-          let needRestore = false;
-          if (cornerRadius === 0 || (isArray(cornerRadius) && (<number[]>cornerRadius).every(num => num === 0))) {
-            // 不需要处理圆角
-          } else {
-            context.beginPath();
-            createRectPath(context, x, y, width, height, cornerRadius, cornerType !== 'bevel');
-            context.save();
-            context.clip();
-            needRestore = true;
-          }
-
           context.setCommonStyle(image, image.attribute, x, y, imageAttribute);
           let repeat = 0;
           if (repeatX === 'repeat') {

diff --git a/packages/vrender/__tests__/browser/src/pages/image.ts b/packages/vrender/__tests__/browser/src/pages/image.ts
@@ -69,19 +69,16 @@ export const page = () => {
   shapes.push(svgImage);
 
   const image = createImage({
-    x: 500,
-    y: 100,
-    width: 100,
-    height: 100,
-    image: urlPng,
-    cornerRadius: 100,
-    // stroke: 'green',
-    // lineWidth: 10,
-    outerBorder: {
-      distance: 50,
-      lineWidth: 100,
-      stroke: 'pink'
-    }
+    x: 50,
+    y: 50,
+    width: 200,
+    height: 200,
+    lineWidth: 10,
+    cornerRadius: 14,
+    stroke: '#000000',
+    fill: 'transparent',
+    image:
+      'http://lf9-dp-fe-cms-tos.byteorg.com/obj/bit-cloud/vchart-editor/upload-images/014d69b2-2731-4daa-9e60-68925fa1e54b.jpg'
   });
   shapes.push(image);