Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TET-858 boolean pill #141

Merged
merged 9 commits into from
May 15, 2024
Merged

feat: TET-858 boolean pill #141

merged 9 commits into from
May 15, 2024

Conversation

golas-m
Copy link
Contributor

@golas-m golas-m commented May 9, 2024

Added the boolean pill component
Figma design

@adrian-potepa
Copy link
Collaborator

The padding-left value is wrong for all beforeComponent prop values:

Zrzut ekranu 2024-05-9 o 16 29 35

Here is image from UI:

Zrzut ekranu 2024-05-9 o 16 28 41

Copy link
Collaborator

@adrian-potepa adrian-potepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Only few small issues to work with.

@golas-m golas-m requested a review from adrian-potepa May 9, 2024 16:51
@adrian-potepa
Copy link
Collaborator

I noticed ker error with story:
image

Copy link
Collaborator

@adrian-potepa adrian-potepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key error in stories

@golas-m golas-m requested a review from adrian-potepa May 13, 2024 16:04
@golas-m golas-m merged commit a3c89de into main May 15, 2024
1 check passed
@golas-m golas-m deleted the feat/TET-858-boolean-pill branch May 15, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants