New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: NO-JIRA Corner Dialog component #135

Merged

mjamrozekvl merged 18 commits into main from feat/corner-dialog

May 7, 2024

Contributor

mjamrozekvl commented Apr 25, 2024 •

edited

Loading

What did you implement?

Implementation of CornerDialog component from Figma.

How it might be Tested?

yarn test
yarn storybook

Go to CornerDialog page: http://localhost:6006/?path=/docs/cornerdialog--docs
Compare implemented component with Figma designs.

Michał Jamrożek added 4 commits

April 24, 2024 10:42


          feat: NO-JIRA basic CornerDialog scaffold

71b4130


          refactor: NO-JIRA styles builder and corner dialog docs

3af19fd


          refactor: NO-JIRA remove unnecessary stylesBuilder directory

2e893a7


          test: NO-JIRA add tests to CornerDialog

37402df

mjamrozekvl temporarily deployed to development

April 25, 2024 06:49

— with

GitHub Actions Inactive

mjamrozekvl marked this pull request as draft

April 25, 2024 06:49


          docs: NO-JIRA add missing figma scenarios

24251e9

mjamrozekvl temporarily deployed to development

April 25, 2024 07:09

— with

GitHub Actions Inactive


          docs: NO-JIRA add custom content story example

14eff3b

mjamrozekvl temporarily deployed to development

April 25, 2024 07:17

— with

GitHub Actions Inactive


          style: NO-JIRA sizes according to figma

b8b9996

mjamrozekvl temporarily deployed to development

April 25, 2024 07:27

— with

GitHub Actions Inactive


          refactor: NO-JIRA export styles

0f36aec

mjamrozekvl temporarily deployed to development

April 25, 2024 07:33

— with

GitHub Actions Inactive

mjamrozekvl changed the title ~~[WIP] feat: NO-JIRA corner dialog~~ feat: NO-JIRA corner dialog

mjamrozekvl self-assigned this

mjamrozekvl marked this pull request as ready for review

April 25, 2024 07:35

mjamrozekvl requested review from adrian-potepa and mwleklinski

April 25, 2024 07:36

mjamrozekvl changed the title ~~feat: NO-JIRA corner dialog~~ feat: NO-JIRA Corner Dialog component


          Merge branch 'main' into feat/corner-dialog

d58fe1b

mjamrozekvl temporarily deployed to development

April 25, 2024 09:15

— with

GitHub Actions Inactive

adrian-potepa reviewed

View reviewed changes

src/components/CornerDialog/CornerDialog.props.ts Outdated Show resolved Hide resolved

adrian-potepa reviewed

View reviewed changes

src/components/CornerDialog/CornerDialog.props.ts Outdated Show resolved Hide resolved

adrian-potepa reviewed

View reviewed changes

src/components/CornerDialog/CornerDialog.styles.ts Outdated Show resolved Hide resolved

adrian-potepa reviewed

View reviewed changes

src/components/CornerDialog/CornerDialog.styles.ts Outdated Show resolved Hide resolved

adrian-potepa reviewed

View reviewed changes

src/components/CornerDialog/CornerDialog.styles.ts Outdated Show resolved Hide resolved

adrian-potepa reviewed

View reviewed changes

src/components/CornerDialog/CornerDialog.styles.ts Outdated Show resolved Hide resolved

adrian-potepa reviewed

View reviewed changes

src/components/CornerDialog/CornerDialog.styles.ts Outdated Show resolved Hide resolved

adrian-potepa requested changes

View reviewed changes

Collaborator

adrian-potepa left a comment

It needs tokens polishing ;)

Michał Jamrożek added 4 commits

April 26, 2024 07:55


          style: NO-JIRA set react event object to optional

7e2c666


          refactor: NO-JIRA exclude size and hasDropdownIndicator from action b…

8a904a2

…utton props


          refactor: NO-JIRA replace color with appropriate variable

2801d3d


          refactor: NO-JIRA replace rest of wrongly defined variables

b8a20b7

mjamrozekvl had a problem deploying to development

April 26, 2024 08:24

— with

GitHub Actions Failure

mjamrozekvl marked this pull request as draft

April 26, 2024 08:24


          fix: NO-JIRA introduce DistributiveOmit typescript utility type

41b0ebe

reason described here: #135 (comment)

mjamrozekvl had a problem deploying to development

April 26, 2024 13:14

— with

GitHub Actions Failure


          style: NO-JIRA disable @typescript-eslint/no-explicit-any rule in Dis…

7f22c1e

…tributiveOmit util

mjamrozekvl temporarily deployed to development

April 26, 2024 13:21

— with

GitHub Actions Inactive

mjamrozekvl marked this pull request as ready for review

April 26, 2024 13:23

mjamrozekvl requested a review from adrian-potepa

April 26, 2024 13:23

Collaborator

adrian-potepa commented Apr 30, 2024

CornerDialog export is missing here: src/index.ts. Could you add also export of Status component?
If src/index.ts doesn't have these exports, the component will be missing in the built package.

adrian-potepa reviewed

View reviewed changes

src/components/CornerDialog/CornerDialog.props.ts Show resolved Hide resolved

adrian-potepa reviewed

View reviewed changes

src/utility-types/DistributiveOmit.ts Show resolved Hide resolved

adrian-potepa reviewed

View reviewed changes

src/docs-components/CornerDialogDocs.tsx Outdated Show resolved Hide resolved

adrian-potepa requested changes

View reviewed changes

Collaborator

adrian-potepa left a comment

Good job! Last polishing with styles and it will be rdy to merge ;)

Michał Jamrożek added 3 commits

May 2, 2024 10:18


          refactor: NO-JIRA remove unnecessary React. type prefix

8eaad1b


          fix: NO-JIRA export CornerDialog and Status components in src/index.t…

b878e4f

…s file


          fix: NO-JIRA use -500 instead of 40px unit

fdd764b

mjamrozekvl temporarily deployed to development

May 2, 2024 08:25

— with

GitHub Actions Inactive

mjamrozekvl requested a review from adrian-potepa

May 2, 2024 09:43

adrian-potepa approved these changes

View reviewed changes

mjamrozekvl merged commit d916220 into main

1 check passed

mjamrozekvl deleted the feat/corner-dialog branch

May 7, 2024 07:52

github-actions bot mentioned this pull request

chore(main): release 1.7.0 #148

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet