Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: TET-863 add Status component #134

Merged
merged 9 commits into from
Apr 25, 2024
Merged

feat: TET-863 add Status component #134

merged 9 commits into from
Apr 25, 2024

Conversation

karolinaszarek
Copy link
Contributor

Status component created

  • added tests
  • created component with styles
  • created a story with example

mwleklinski
mwleklinski requested changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@mwleklinski mwleklinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Kudos for creating Docs page similar to the Component's Figma Page, there is a few small issues I found. It should be fairly simple to fix.

src/components/Status/Status.props.ts Outdated Show resolved Hide resolved
src/components/Status/stylesBuilder/index.ts Outdated Show resolved Hide resolved
src/components/Status/Status.tsx Show resolved Hide resolved
src/components/Status/Status.props.ts Outdated Show resolved Hide resolved
src/components/Status/Status.styles.ts Outdated Show resolved Hide resolved
adrian-potepa
adrian-potepa requested changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@adrian-potepa adrian-potepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs some small fixes, but it's rly good job 👌

@karolinaszarek @mwleklinski
feat: TET-863 add type to an import
917960c 
Co-authored-by: Mateusz Wlekliński <[email protected]>
mwleklinski
mwleklinski approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@mwleklinski mwleklinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, great! thanks for the fixes

adrian-potepa
adrian-potepa requested changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@adrian-potepa adrian-potepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some polishing in Storybook :)

@adrian-potepa
Copy link
Collaborator

image

Some 🥚 in dot place ;)

@karolinaszarek
Copy link
Contributor Author

image Some 🥚 in dot place ;)

Thanks for checking, I missed it. It's fixed

@karolinaszarek karolinaszarek merged commit c81b1a6 into main Apr 25, 2024
1 check passed
@karolinaszarek karolinaszarek deleted the feat/TET-863-status branch April 25, 2024 08:35
@github-actions github-actions bot mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwleklinski mwleklinski mwleklinski approved these changes

@adrian-potepa adrian-potepa adrian-potepa approved these changes

@tpiechaczek tpiechaczek Awaiting requested review from tpiechaczek

@MartaKozina010 MartaKozina010 Awaiting requested review from MartaKozina010

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karolinaszarek @adrian-potepa @mwleklinski