Add helper methods to Yaml{Encodr, Decoder, Codec} #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbialy
requested changes
May 31, 2024
| def imap[T1](f: T => T1)(g: T1 => T): YamlCodec[T1] = | ||
| YamlCodec.from(self.map(f), self.contramap(g)) | ||
|
|
||
| def iemap[T1](f: T => Either[ConstructError, T1])(g: T1 => T): YamlCodec[T1] = |
There was a problem hiding this comment.
is there a better name for this shape of iso map? iemap is actively hostile (imap is too, tbh) if you're not familiar with ct and/or haskell
|
Some tests would be nice too, I know that it's basically if it compiles, it works kind of a change but still - let's say it's just for breakage detection |
sideeffffect
changed the title
lbialy
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.