Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies.md to mention jitpack #2458

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

doofin
Copy link
Contributor

@doofin doofin commented Oct 10, 2023

No description provided.

@MaciejG604
Copy link
Contributor

MaciejG604 commented Oct 11, 2023

Hi @doofin, thank you for contributing, that's a valid remark.

I think the information about jitpack would fit much better into the table in the Predefined repositories section of the file you've updated.

Also It would be nice if you rebased your commit onto the stable branch and changed the target branch for this PR so that the website can be updated right away. (more info here)

@MaciejG604 MaciejG604 changed the base branch from main to stable October 11, 2023 13:05
@MaciejG604 MaciejG604 changed the base branch from stable to main October 11, 2023 13:09
@Gedochao Gedochao changed the base branch from main to stable October 20, 2023 08:07
@Gedochao
Copy link
Contributor

Gedochao commented Oct 20, 2023

I squashed the 2 commits (please take care about keeping the commit history clean) and rebased it on top of stable (purely docs changes should go straight there, as mentioned).
Please pay attention to those things, it gets PRs merged a lot faster if we don't have to clean it up.
All the guidelines are in CONTRIBUTING.md

Regardless, thanks for the contribution!

@doofin
Copy link
Contributor Author

doofin commented Oct 20, 2023

thanks @Gedochao for the help! I've been messing around with the rebase and branch switch

@Gedochao Gedochao merged commit 3501580 into VirtusLab:stable Oct 20, 2023
38 checks passed
@doofin doofin deleted the patch-1 branch October 25, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants