Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more configuration for publish #2435

Merged

Conversation

MaciejG604
Copy link
Contributor

@MaciejG604 MaciejG604 commented Oct 3, 2023

Since 0.1.5 coursier-publish allows for retrying of sonatype's staging repository operations, the number of retries can be configured.
Since 0.1.6 it allows for setting timeouts for uploading files.
Those options could not be configured from Scala CLI, this PR fixes that.

Added for uploading:

  • connection timeout - SAME OPTION USED IN BOTH
  • the number of retries on connection timeout
  • timeout when waiting for server response - should be useful when uploading large packages

Added for stagin repo:

  • connection timeout - SAME OPTION USED IN BOTH
  • number of retries on failure
  • base wait time between the retries

New configuration options reside in PublishConnectionOptions.scala

@MaciejG604 MaciejG604 force-pushed the add-more-configuration-for-publish branch from cc73322 to 42b8053 Compare October 3, 2023 07:11
@MaciejG604 MaciejG604 force-pushed the add-more-configuration-for-publish branch from 42b8053 to b56ad1b Compare October 3, 2023 07:39
@MaciejG604 MaciejG604 marked this pull request as ready for review October 3, 2023 14:05
@MaciejG604 MaciejG604 requested a review from Gedochao October 3, 2023 14:05
@MaciejG604 MaciejG604 merged commit 89c2758 into VirtusLab:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants